Skip to content

Conversation

@ricksu978
Copy link
Member

Why need this change? / Root cause:

Migrate to Azure

Changes made:

  • GitHub Actions Yaml files

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR migrates the CI/CD pipeline from AWS deployment to Azure, converting from a simple artifact-based deployment to a containerized deployment workflow using GitHub Container Registry and Azure App Service.

  • Replaced AWS deployment with Azure App Service deployment using Docker containers
  • Added Docker build and push steps to GitHub Container Registry
  • Introduced a separate deploy job with Azure authentication and container deployment

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 2, 2025

@ricksu978 ricksu978 requested a review from Copilot November 2, 2025 01:21
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

name: Build on GitHub
runs-on: ubuntu-latest
outputs:
image: ${{ env.CONTAINER_REGISTRY }}/${{ env.CONTAINER_REPOSITORY }}:${{ github.sha }}
Copy link

Copilot AI Nov 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Job outputs cannot reference workflow-level environment variables using env. The output value will be empty at runtime. Consider using a step output or directly referencing vars.CONTAINER_REGISTRY and vars.CONTAINER_REPOSITORY in the output expression.

Suggested change
image: ${{ env.CONTAINER_REGISTRY }}/${{ env.CONTAINER_REPOSITORY }}:${{ github.sha }}
image: ${{ vars.CONTAINER_REGISTRY }}/${{ vars.CONTAINER_REPOSITORY }}:${{ github.sha }}

Copilot uses AI. Check for mistakes.
Comment on lines +59 to +63
shell: pwsh
run: docker build `
-t ${{ env.CONTAINER_REGISTRY }}/${{ env.CONTAINER_REPOSITORY }}:${{ github.sha }} `
-f ${{ env.DOCKERFILE_PATH }} `
--build-arg JAR_FILENAME=${{ env.JAR_OUTPUT_PATH }}/${{ env.JAR_FILENAME }}.jar `
Copy link

Copilot AI Nov 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using PowerShell syntax (pwsh shell with backticks for line continuation) on ubuntu-latest is unconventional. The standard approach for multi-line commands on Linux runners is to use bash shell with backslashes. Consider changing to shell: bash and using backslashes (\) for line continuation.

Suggested change
shell: pwsh
run: docker build `
-t ${{ env.CONTAINER_REGISTRY }}/${{ env.CONTAINER_REPOSITORY }}:${{ github.sha }} `
-f ${{ env.DOCKERFILE_PATH }} `
--build-arg JAR_FILENAME=${{ env.JAR_OUTPUT_PATH }}/${{ env.JAR_FILENAME }}.jar `
shell: bash
run: docker build \
-t ${{ env.CONTAINER_REGISTRY }}/${{ env.CONTAINER_REPOSITORY }}:${{ github.sha }} \
-f ${{ env.DOCKERFILE_PATH }} \
--build-arg JAR_FILENAME=${{ env.JAR_OUTPUT_PATH }}/${{ env.JAR_FILENAME }}.jar \

Copilot uses AI. Check for mistakes.
@ricksu978 ricksu978 merged commit 280ac7f into main Nov 2, 2025
9 of 11 checks passed
@ricksu978 ricksu978 deleted the azure-migration branch November 2, 2025 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants