-
Notifications
You must be signed in to change notification settings - Fork 7
Azure migration #242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Azure migration #242
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR migrates the CI/CD pipeline from AWS deployment to Azure, converting from a simple artifact-based deployment to a containerized deployment workflow using GitHub Container Registry and Azure App Service.
- Replaced AWS deployment with Azure App Service deployment using Docker containers
- Added Docker build and push steps to GitHub Container Registry
- Introduced a separate deploy job with Azure authentication and container deployment
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
1f5e1ff to
f4c2258
Compare
94fb986 to
c31a808
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| name: Build on GitHub | ||
| runs-on: ubuntu-latest | ||
| outputs: | ||
| image: ${{ env.CONTAINER_REGISTRY }}/${{ env.CONTAINER_REPOSITORY }}:${{ github.sha }} |
Copilot
AI
Nov 2, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Job outputs cannot reference workflow-level environment variables using env. The output value will be empty at runtime. Consider using a step output or directly referencing vars.CONTAINER_REGISTRY and vars.CONTAINER_REPOSITORY in the output expression.
| image: ${{ env.CONTAINER_REGISTRY }}/${{ env.CONTAINER_REPOSITORY }}:${{ github.sha }} | |
| image: ${{ vars.CONTAINER_REGISTRY }}/${{ vars.CONTAINER_REPOSITORY }}:${{ github.sha }} |
| shell: pwsh | ||
| run: docker build ` | ||
| -t ${{ env.CONTAINER_REGISTRY }}/${{ env.CONTAINER_REPOSITORY }}:${{ github.sha }} ` | ||
| -f ${{ env.DOCKERFILE_PATH }} ` | ||
| --build-arg JAR_FILENAME=${{ env.JAR_OUTPUT_PATH }}/${{ env.JAR_FILENAME }}.jar ` |
Copilot
AI
Nov 2, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using PowerShell syntax (pwsh shell with backticks for line continuation) on ubuntu-latest is unconventional. The standard approach for multi-line commands on Linux runners is to use bash shell with backslashes. Consider changing to shell: bash and using backslashes (\) for line continuation.
| shell: pwsh | |
| run: docker build ` | |
| -t ${{ env.CONTAINER_REGISTRY }}/${{ env.CONTAINER_REPOSITORY }}:${{ github.sha }} ` | |
| -f ${{ env.DOCKERFILE_PATH }} ` | |
| --build-arg JAR_FILENAME=${{ env.JAR_OUTPUT_PATH }}/${{ env.JAR_FILENAME }}.jar ` | |
| shell: bash | |
| run: docker build \ | |
| -t ${{ env.CONTAINER_REGISTRY }}/${{ env.CONTAINER_REPOSITORY }}:${{ github.sha }} \ | |
| -f ${{ env.DOCKERFILE_PATH }} \ | |
| --build-arg JAR_FILENAME=${{ env.JAR_OUTPUT_PATH }}/${{ env.JAR_FILENAME }}.jar \ |



Why need this change? / Root cause:
Migrate to Azure
Changes made: