feat: update various game server distro compatibility's #4853
Conversation
* Corrected the operating system version for `Vintage Story` from `ubuntu-22.04` to `ubuntu-24.04`. * Ensures compatibility with the latest server requirements.
* Adjusted version checks for supported distributions. * Added specific error messages for unsupported game titles based on OS version.
There was a problem hiding this comment.
Pull Request Overview
This PR updates game compatibility and dependency requirements for LinuxGSM. The changes move distro detection earlier in the dependency checking process, add explicit version constraints for specific games on Ubuntu and Debian, remove obsolete SSL library dependencies for Sven Co-op, and update the supported distribution versions for Sven Co-op and Vintage Story to Ubuntu 24.04.
Key changes:
- Adds distribution version checks to prevent installation of bf1942/bfv on Ubuntu > 22.04 or Debian > 12, and onset/btl on Ubuntu > 20.04 or Debian > 11
- Removes
libssl1.1:i386dependency for Sven Co-op across all Ubuntu and Debian versions - Updates Sven Co-op and Vintage Story support to Ubuntu 24.04 in serverlist.csv
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| lgsm/modules/check_deps.sh | Moves info_distro.sh call earlier and adds version compatibility checks for specific games |
| lgsm/data/ubuntu-*.csv | Removes libssl1.1:i386 dependency for Sven Co-op across multiple Ubuntu versions |
| lgsm/data/debian-*.csv | Removes libssl1.1:i386 dependency for Sven Co-op across Debian 9, 10, and 11 |
| lgsm/data/serverlist.csv | Updates supported Ubuntu version for Sven Co-op and Vintage Story from 20.04/22.04 to 24.04 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| info_distro.sh | ||
| # These titles are only supported up to Ubuntu 22.04 (Jammy) and Debian 12 (Bookworm). | ||
| if { [ "${distroid}" == "ubuntu" ] && dpkg --compare-versions "${distroversion}" "gt" "22.04"; } || { [ "${distroidlike}" == "debian" ] && dpkg --compare-versions "${distroversion}" "gt" "12"; }; then |
There was a problem hiding this comment.
Inconsistent use of distroidlike instead of distroid for Debian check. The variable distroidlike represents derivative relationships (e.g., Ubuntu's distroidlike is "debian"), not the actual distro ID. For actual Debian installations, this should check distroid == \"debian\" to properly detect Debian systems. The current logic may fail to detect actual Debian installations.
| fi | ||
|
|
||
| # These titles are only supported up to Ubuntu 20.04 and Debian 11 (and Debian-like derivatives). | ||
| if { [ "${distroid}" == "ubuntu" ] && dpkg --compare-versions "${distroversion}" "gt" "20.04"; } || { [ "${distroidlike}" == "debian" ] && dpkg --compare-versions "${distroversion}" "gt" "11"; }; then |
There was a problem hiding this comment.
Inconsistent use of distroidlike instead of distroid for Debian check. The variable distroidlike represents derivative relationships (e.g., Ubuntu's distroidlike is "debian"), not the actual distro ID. For actual Debian installations, this should check distroid == \"debian\" to properly detect Debian systems. The current logic may fail to detect actual Debian installations.
Description
This PR updates compatibilities of various game servers that no longer work on newer distros
Fixes #[issue]
Type of change
Checklist
PR will not be merged until all steps are complete.
developbranch as its base.Documentation
If documentation does need updating either update it by creating a PR (preferred) or request a documentation update.
Thank you for your Pull Request!