-
-
Notifications
You must be signed in to change notification settings - Fork 67
Blossoming Pots #1070
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Bloo-dev
merged 60 commits into
Gamemode4Dev:master
from
runcows:gm4-blossoming-pots-intial
Feb 9, 2025
Merged
Blossoming Pots #1070
Changes from 1 commit
Commits
Show all changes
60 commits
Select commit
Hold shift + click to select a range
b20c7fb
Initial Commit
runcows 85a3579
Refactor to only summon displays as they are used.
runcows 884bc5c
Added main types
runcows 6488bd1
Merge branch 'master' of https://github.com/Gamemode4Dev/GM4_Datapack…
runcows b85c91a
slight corrections in set_storages
runcows a756fc1
Edit raycasts to use player.block_interaction_range
runcows 25f2d10
Added overlay for block_interaction_range since mojang removed the pl…
runcows 43398e1
Cleaning up some comments
runcows 669528f
Remove overlay because I didn't need to do it at all
runcows 0a18491
Removed stages and plantables talked about in meeting. Still need to …
runcows 3f42c46
Fix decorated pot plants not initializing when more items than stages
runcows 0d1e89f
Changes to plantables as discussed
runcows 4b10837
Merge branch 'master' of https://github.com/Gamemode4Dev/GM4_Datapack…
runcows 30340bf
Added overlay for 1.21.4 and changed storage version_history array to…
runcows e2aab6e
Fix decorated pot temp marker not being removed when pot is empty
runcows 3f5955f
Simplify block interaction range raycast range to not need scoreboard…
runcows 8d0e9ff
Changes from Bloo's comments
runcows 7ce25a8
Adding icon
runcows d5a1a67
Fixing my new entry in contributors.json not being inserted alphabeti…
runcows f55f575
Remove cocoa beans from README
runcows 8de3e09
Fix break and replace partial plant cannibalizing
runcows 002d60c
Fix plant rotation not being locked for newly summoned displays of a …
runcows da4351a
Implement Bloo's suggestion for in_pot changes to not need to select …
runcows 63a4bf3
Merge branch 'master' of https://github.com/Gamemode4Dev/GM4_Datapack…
runcows a897a52
Merge branch 'master' of https://github.com/Gamemode4Dev/GM4_Datapack…
runcows 9556ff8
Add webp animation (20fps, compressed to 351 KB)
runcows a2035fb
Change my contributors.json link to bluesky for upcoming changes
runcows 542d9b0
Merge branch 'master' of https://github.com/Gamemode4Dev/GM4_Datapack…
runcows 9ae9e04
Merge branch 'master' of https://github.com/Gamemode4Dev/GM4_Datapack…
runcows 7db3bcb
Update header of gm4_blossoming_pots/data/gm4_blossoming_pots/functio…
runcows 8b19a34
Change function header "with" lines to follow the style bloo specifie…
runcows dad1bd0
Merge branch 'master' of https://github.com/Gamemode4Dev/GM4_Datapack…
runcows 06ed2ae
Change as_player -> as marker selectors to limit 1
runcows bd40b5b
Change player rotation data to use storage instead of marker data
runcows b5e4698
Fix empty hand scenario being overlooked by player rotation changes
runcows 4127daf
Change empty hand interact on flower pot to summon an item at players…
runcows ebff299
Assorted changes from review session
runcows a07dd26
Rename advancements
runcows eae18a5
Refactor vanilla flower pot handling
runcows 362ba7c
Comments on potential changes
runcows 6db62ad
Refactor decorated pot handling
runcows 1c81619
Rename vanilla_pot_handling/in_pot
runcows 5331209
Refactor flower pot handling
runcows 9822155
Function header changes
runcows 8100f28
Change distance range to be self consistent with module
runcows 264108e
Condense flower pot clean up
runcows 4c96a48
Combine like selectors into one function
runcows b02c00e
Comment format change
runcows bdcf7d9
Fix temp storage not being reset
runcows ff1b1c9
Remove player nbt UUID check
runcows 0fdcddc
Fix issues from changes
runcows c698378
Merge branch 'master' of https://github.com/Gamemode4Dev/GM4_Datapack…
runcows 0eba8db
Wrap marker data in gm4_blossoming_pots tag
runcows b282b53
Replace FallDistance stage tracking with Scoreboard
runcows 5f30f5f
Update gm4_blossoming_pots/beet.yaml
runcows e83f651
Update gm4_blossoming_pots/beet.yaml
runcows cc83d68
Update gm4_blossoming_pots/data/gm4_blossoming_pots/function/decorate…
runcows fd7ca5e
Merge branch 'gm4-blossoming-pots-intial' of https://github.com/runco…
runcows ff074b0
Fix main marker cleanup macro not reflecting change in marker data wr…
runcows b0f22d5
Fix anchored eyes not moving execution context on first raycast loop
runcows File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 changes: 15 additions & 0 deletions
15
...ossoming_pots/overlay_48/data/gm4_blossoming_pots/function/decorated/as_player.mcfunction
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| # Sets up raycast, then redirects to as_marker, then revokes advancement | ||
| # @s = player who interacted with a decorated pot | ||
| # at @s | ||
| # run from advancement gm4_blossoming_pots:item_in_pot | ||
|
|
||
| # Raycast for the pot (set up range and search) | ||
| execute store result score @s gm4_blossoming_pots.range run attribute @s minecraft:player.block_interaction_range get 1 | ||
runcows marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| scoreboard players operation @s gm4_blossoming_pots.range *= $raycast_multiplier gm4_blossoming_pots.range | ||
| execute anchored eyes run function gm4_blossoming_pots:decorated/raycast/loop | ||
|
|
||
| execute as @e[type=minecraft:marker,sort=nearest,tag=gm4_blossoming_pots.temp.decorated_pot] at @s \ | ||
| align xyz positioned ~.5 ~.5 ~.5 run function gm4_blossoming_pots:decorated/as_marker with block ~ ~ ~ item | ||
|
|
||
| # Reset advancement | ||
| advancement revoke @s only gm4_blossoming_pots:item_in_pot | ||
15 changes: 15 additions & 0 deletions
15
gm4_blossoming_pots/overlay_48/data/gm4_blossoming_pots/function/flower/as_player.mcfunction
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| # Sets up raycast, then redirects to as_marker, then revokes advancement | ||
| # @s = player who interacted with an empty flower pot | ||
| # at @s | ||
| # run from advancement gm4_blossoming_pots:interact_flower_pot | ||
|
|
||
| # Raycast for the pot (set up range and search) | ||
| execute store result score @s gm4_blossoming_pots.range run attribute @s minecraft:player.block_interaction_range get 1 | ||
| scoreboard players operation @s gm4_blossoming_pots.range *= $raycast_multiplier gm4_blossoming_pots.range | ||
| execute anchored eyes run function gm4_blossoming_pots:flower/raycast/loop | ||
|
|
||
| execute as @e[type=minecraft:marker,sort=nearest,tag=gm4_blossoming_pots.temp.flower_pot] at @s \ | ||
| align xyz positioned ~.5 ~.5 ~.5 run function gm4_blossoming_pots:flower/as_marker with entity @s data | ||
|
|
||
| # Reset advancement | ||
| advancement revoke @s only gm4_blossoming_pots:interact_flower_pot |
15 changes: 15 additions & 0 deletions
15
...ots/overlay_48/data/gm4_blossoming_pots/function/flower/vanilla_pots/as_player.mcfunction
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| # Sets up raycast, then redirects to as_marker, then revokes advancement | ||
| # @s = player who interacted with a filled vanilla flower pot | ||
| # at @s | ||
| # run from advancement gm4_blossoming_pots:interact_vanilla_flower_pot | ||
|
|
||
| # Raycast for the pot (set up range and search) | ||
| execute store result score @s gm4_blossoming_pots.range run attribute @s minecraft:player.block_interaction_range get 1 | ||
| scoreboard players operation @s gm4_blossoming_pots.range *= $raycast_multiplier gm4_blossoming_pots.range | ||
| execute anchored eyes run function gm4_blossoming_pots:flower/vanilla_pots/raycast/loop | ||
|
|
||
| execute as @e[type=minecraft:marker,sort=nearest,tag=gm4_blossoming_pots.temp.vanilla_flower_pot] at @s \ | ||
| align xyz positioned ~.5 ~.5 ~.5 run function gm4_blossoming_pots:flower/vanilla_pots/as_marker | ||
|
|
||
| # Reset advancement | ||
| advancement revoke @s only gm4_blossoming_pots:interact_vanilla_flower_pot |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.