Survival Refightalized & Monsters Unbound 1.21.5 #1108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
misode
added
feature-update
- spamming the shield now disables parries - all elite head blocks now have binding curse - pearlescent laser no longer pierces armor
- re-added chicken jockeys for Lava Chicken music disk - added more sounds to shield parry
misode
approved these changes
Jul 14, 2025
Member
misode
left a comment
misode
left a comment
There was a problem hiding this comment.
I've looked through a fair amount of the code now. Great job on the documentation and general neat-ness of the mcfunction files! I've got a couple of nitpicks, but otherwise this looks good to merge.
...und/data/gm4_monsters_unbound/function/mob/process/elite/pearlescent/laser_damage.mcfunction
Outdated
Show resolved
Hide resolved
|
|
||
| # initiate unless mob is pre-marked | ||
| execute unless entity @s[tag=gm4_sr_processed] if dimension minecraft:overworld run function gm4_survival_refightalized:mob/init/calc_difficulty_overworld | ||
| execute unless entity @s[tag=gm4_sr_processed] unless dimension minecraft:overworld run function gm4_survival_refightalized:mob/init/calc_difficulty_else |
Member
There was a problem hiding this comment.
This check should use a dimension tag so that other data packs can make overworld-like dimensions where mobs behave the same as in minecraft:overworld.
Member
Author
There was a problem hiding this comment.
Is there such a thing as a dimension tag? I can't find anything about it
...l_refightalized/data/gm4_survival_refightalized/function/mob/init/mob_type/zombie.mcfunction
Outdated
Show resolved
Hide resolved
...alized/data/gm4_survival_refightalized/function/mob/process/arrow/tick_fire_delay.mcfunction
Show resolved
Hide resolved
gm4_survival_refightalized/data/gm4_survival_refightalized/function/main.mcfunction
Outdated
Show resolved
Hide resolved
- death messages only play if showDeathMessages is true - removed useless function tag calls - improved baby zombie predicate - renamed tick_fire_delay function to clock_fire_delay
github-actions bot
pushed a commit
that referenced
this pull request
Aug 11, 2025
* add 1.21.4 modules * what even happened here? * update survival refightalized to 1.21.5 * add missing headers * fix monsters unbound for 1.21.5 * add missing headers and translations * some of the playtest feedback * add custom death messages * fix the last few playtest things - spamming the shield now disables parries - all elite head blocks now have binding curse - pearlescent laser no longer pierces armor * update to 1.21.7 - re-added chicken jockeys for Lava Chicken music disk - added more sounds to shield parry * update from misode's comments - death messages only play if showDeathMessages is true - removed useless function tag calls - improved baby zombie predicate - renamed tick_fire_delay function to clock_fire_delay * add empty function tags
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR serves to replace Combat Expanded with Survival Refightalized & Monsters Unbound. The last part, named Augmented Armor is not included here, this is as replacement of the old PR (#1025)
Survival Refightalized
Monsters Unbound