Crossbow Cartridges 1.21.5: Fixes projectile ownership #1204
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EpyonProjects
force-pushed
the
crossbow-cartridges-1-21-5-ownership-fix
branch
2 times, most recently
from
8f9493d to
ba6e0c6
Compare
Member
|
This PR is impossible to review because it has so many unrelated commits. Please rebase or cherry-pick this and select the right base. |
EpyonProjects
force-pushed
the
crossbow-cartridges-1-21-5-ownership-fix
branch
from
ba6e0c6 to
f6d4824
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like this was incorrectly set from the start. projectile.uuid set from @s UUID cannot work entities cannot have the same UUID. This most likely was meant to set the projectile.Owner (or .owner, in the case of tnt) as to attribute a projectile to the original player. This works for arrows but not for the ones this PR modifies (TNT, fireballs, and wind charges) as those are freshly spawned.
This should address #1037 where moderation tools were not able to log potential grief/pvp cases