End Fishing - Switch enderpuff to on_ground check

[runcows]

Closes #1191

[Bloo-dev]

I am somewhat worried about this change. I remember the enderpuff actually did this check, but we removed it as reading the players on_ground tag was too expensive. Does the use of predicates make this any cheaper or is this simply a NBT check with some nice paint over it?

[BPR02]

Predicates are significantly better than nbt checks because NBT checks require parsing the entire player nbt (which is massive since it includes every recipe that was unlocked). In theory a block check is still less expensive, but the predicate makes the check fully work as intended.

[runcows]

I did some quick benchmarking on this to check and can confirm what Beeps said.
I tested:

• the block check we had
• the predicate check from this PR
• a predicate check for the NBT tag OnGround

I found that the block check is slightly better than the predicate from this PR, although sometimes close enough that I don't know if it would hold up to further testing. But the predicate in this PR is significantly better than an NBT checking predicate.

[runcows]

Through the profiling, I did also just notice we have this in the main function:

tag @a[tag=gm4_ef_fall,nbt={OnGround:0b}] remove gm4_ef_fall

I can open a PR to swap out the NBT check here for a predicate tomorrow when I wake up o7