End Fishing - Remove OnGround player NBT check from main
#1233
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
misode
approved these changes
Dec 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed a predicate file for use in the selector; also swapped out the
enderpuff/processpredicate to refer to this file.I am considering a PR to swap every
OnGroundnbt check over to a predicate where it makes sense. I was thinking about it because for metallurgy (#1192) I've already done a predicate conversion like this PR and there are more modules that are still using the nbtOnGroundwhere they don't need to. If there's interest in that, I can cannibalize this PR for that and create agm4:on_groundpredicate in base.