Add test case for admin login

[Gared]

No description provided.

[Copilot]

Pull Request Overview

Adds a test case and implementation updates to verify admin login functionality during scanning.

• Updated getAdmin in ScannerService to POST to admin-auth/ and fall back to GET admin/
• Added a new GitHub Actions job EtherpadAdminLogin to run an end-to-end admin login check

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File	Description
src/Service/ScannerService.php	Replace GET with POST admin-auth, handle auth responses and fallback GET request
.github/workflows/e2e-test.yml	Add new EtherpadAdminLogin job to test admin login in CI

Comments suppressed due to low confidence (1)

.github/workflows/e2e-test.yml:395

• E2E tests cover successful admin login but lack a test for failed login scenarios. Consider adding a case with incorrect credentials to verify the false path.

          command_line: bin/console.php ether:scan http://localhost:9001

[Copilot]

Missing return after callback in the second catch block. Without an explicit return, code after this block could execute, causing multiple callbacks or unintended behavior. Add return; after invoking the callback.

Suggested change

	$callback->onScanAdminResult($user, $password, false);
	$callback->onScanAdminResult($user, $password, false);
	return;

[Copilot]

[nitpick] Catching all GuzzleExceptions without logging or rethrowing hides potential issues beyond authentication failures. Consider logging the exception or rethrowing unexpected errors to improve debuggability.

[Copilot]

[nitpick] The callback invocation is duplicated across multiple branches. Consider refactoring to extract a helper or iterate endpoints to reduce duplication.

Suggested change

	$callback->onScanAdminResult($user, $password, $response->getStatusCode() === 200);
	return;
	} catch (GuzzleException $e) {
	if ($e->getCode() === 401) {
	$callback->onScanAdminResult($user, $password, false);
	$this->invokeScanAdminResult($callback, $user, $password, $response->getStatusCode() === 200);
	return;
	} catch (GuzzleException $e) {
	if ($e->getCode() === 401) {
	$this->invokeScanAdminResult($callback, $user, $password, false);