Conversation
|
@noorbuchi please check the feature and approve its merge. Thank you. |
|
Hello @kahesayn, thanks for opening this PR! I will take a look at your changes very soon and provide feedback before merging. Thanks again for all the work! |
noorbuchi
left a comment
There was a problem hiding this comment.
In addition to the Nati.json file, can you please remove the compiled file stockHandler. I will be looking more extensively into this PR but these are just some general changes to make.
|
For other aspects of this PR, I'm curious, how was the |
This file was downloaded from this link: https://www.nasdaq.com/market-activity/stocks/screener. I used this file as way to get a list of openly traded companies and their corresponding tickers. In this manner, the user can just look up the name of the company instead of the ticker, and then the ticker for this company can be retrieved from the csv file and then inputed into yfinance. |
|
@kahesayn thanks for the clarification. I have two main suggestions when it comes to that.
I'm open to other suggestions or comments if you have any. Thanks again for your work on this! |
Implementation of the company search has been complete.