Skip to content

Issue#2#7

Open
kahesayn wants to merge 7 commits intoGatorGallery:mainfrom
kahesayn:issue#2
Open

Issue#2#7
kahesayn wants to merge 7 commits intoGatorGallery:mainfrom
kahesayn:issue#2

Conversation

@kahesayn
Copy link

Implementation of the company search has been complete.

@kahesayn
Copy link
Author

@noorbuchi please check the feature and approve its merge. Thank you.

@noorbuchi
Copy link
Collaborator

Hello @kahesayn, thanks for opening this PR! I will take a look at your changes very soon and provide feedback before merging. Thanks again for all the work!

@noorbuchi noorbuchi self-requested a review May 21, 2021 16:28
Copy link
Collaborator

@noorbuchi noorbuchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to the Nati.json file, can you please remove the compiled file stockHandler. I will be looking more extensively into this PR but these are just some general changes to make.

@noorbuchi
Copy link
Collaborator

For other aspects of this PR, I'm curious, how was the nasdaq_screener.csv file generated or downloaded.

@kahesayn
Copy link
Author

For other aspects of this PR, I'm curious, how was the nasdaq_screener.csv file generated or downloaded.

This file was downloaded from this link: https://www.nasdaq.com/market-activity/stocks/screener. I used this file as way to get a list of openly traded companies and their corresponding tickers. In this manner, the user can just look up the name of the company instead of the ticker, and then the ticker for this company can be retrieved from the csv file and then inputed into yfinance.

@noorbuchi
Copy link
Collaborator

@kahesayn thanks for the clarification. I have two main suggestions when it comes to that.

  1. New companies can always go public so if we chose to continue with this approach, there should be an automated way to update the csv file to reflect the changes happening in the market.
  2. Sometimes, its much easier to search for a stock using the ticker symbol since it's more specific and because some company names can be long and unclear so I think there should still be an option to search using the ticker symbol.

I'm open to other suggestions or comments if you have any. Thanks again for your work on this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants