fix: Correct G92 E reset after deferred perimeters (issue #17)#53
Open
adele-with-a-b wants to merge 1 commit intoGeekDetour:mainfrom
Open
fix: Correct G92 E reset after deferred perimeters (issue #17)#53adele-with-a-b wants to merge 1 commit intoGeekDetour:mainfrom
adele-with-a-b wants to merge 1 commit intoGeekDetour:mainfrom
Conversation
In absolute extrusion mode, G92 E reset used myline.previous.e which includes the deferred perimeters' extrusion. Since those were replayed with relative extrusion (M83), the firmware E register never advanced. Now uses last_noninternalperimeter_state.e instead. Closes GeekDetour#17
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Absolute Extrusion Fix
In absolute extrusion mode (used by PrusaSlicer), the
G92 Ereset after deferred perimeters usedmyline.previous.e— the E value that includes the deferred perimeters' extrusion. But since those perimeters were replayed with relative extrusion (M83), the firmware's E register never advanced by that amount.This caused a massive blob at the start of the next feature (outer wall) as reported in #17.
Fix
G92 Enow usesself.last_noninternalperimeter_state.e— the E value from before the deferred perimeters. Applied to bothgenerate_deffered_perimeters()and the kept perimeters path.Impact
Closes #17