-
Notifications
You must be signed in to change notification settings - Fork 7
Adds illegal anonymous function error msg #30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ruiconti
wants to merge
10
commits into
Gelio:master
Choose a base branch
from
ruiconti:rconti/adds-illegal-annonymous-function-error-msg
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 2 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
d17deb8
Adds rule that verifies if anonymous function is properly used
ruiconti b75e46c
Adds tiny set of tests
ruiconti e41cd6e
Simplifies and removes redundancy from rule's conditional
ruiconti e8f1a5a
Adds more information to the error message
ruiconti 9108ec2
Adds a test scenario that disambigues the need for this specific rule
ruiconti 39cd396
Add missing conditional guard
ruiconti b2d11ae
Fixes deprecated ubuntu vmImage value
ruiconti 7e4048f
Merge branch 'master' into rconti/adds-illegal-annonymous-function-er…
ruiconti e8a4a70
Adds missing check for callback being a valid hook identifier
ruiconti eca2ac7
Adds test scenario to cover for potential amibguous matching
ruiconti File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| const IllegalComponent = wrapper(function() { | ||
| useEffect(() => {}); | ||
| ~~~~~~~~~~~~~~~~~~~ [Hook is in an anonymous function that is passed to an illegal callback] | ||
ruiconti marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| }) | ||
|
|
||
| const LegalAnonymousComponent = function() { | ||
| useEffect(() => {}); | ||
| } | ||
|
|
||
| const ForwardedComponent = React.forwardRef(function(props, ref) { | ||
| useEffect(() => { | ||
| console.log("I am legal") | ||
| }); | ||
| }) | ||
|
|
||
| const MemoizedComponent = React.memo((props) => { | ||
| const [state, setState] = React.useState(props.initValue); | ||
| return <span>{state}</span> | ||
| }) | ||
ruiconti marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.