Safely detect and set database collation dynamically to avoid CHARSET… #62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… issue on database engine This commit fixes installer failures on MariaDB by removing hard-coded MySQL 8–only collations. Key changes: - Added automatic detection of MySQL vs MariaDB at install time - Dynamically selects a compatible utf8mb4 collation - MariaDB / MySQL < 8 → utf8mb4_unicode_ci - MySQL 8+ → utf8mb4_0900_ai_ci - Replaced hard-coded utf8mb4_0900_ai_ci usages in CREATE TABLE statements - Ensured utf8mb4 charset is set on the database connection This makes the installer portable across: - MariaDB 10.x (including CloudLinux) - MySQL 5.7 - MySQL 8+ No schema, data, or runtime logic changes beyond compatibility fixes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… issue on database engine
This commit fixes installer failures on MariaDB by removing hard-coded MySQL 8–only collations.
Key changes:
This makes the installer portable across:
No schema, data, or runtime logic changes beyond compatibility fixes.