allow manual breaks in plot_er()#16
Merged
yoshidk6 merged 7 commits intoGenentech:mainfrom Dec 18, 2025
Merged
Conversation
Collaborator
|
Hi @djnavarro ! I'm planning to implement a new change based on this #17. I wonder if this pull request can be considered mature enough to merge to main? |
Contributor
Author
|
Hi @yoshidk6! I think it's okay to merge this, yes :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tools PR associated with Genentech/BayesERbook#12. The goal is to support a manual
bin_breaksoption within theoptions_orig_datalist argument, which would apply for binary outcome plots only, and would overriden_binsif both are supplied