Fix: test_trace_df warnings with unknown srcrefs#79
Merged
Conversation
maksymiuks
approved these changes
Feb 13, 2025
Collaborator
maksymiuks
left a comment
maksymiuks
left a comment
There was a problem hiding this comment.
Looks like we dodged the bullet! Thanks a lot!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses an issue discovered in #78
I haven't exactly pinned down why
bitopsseems unable to capturesrcrefsincovr, but this fix should be in place regardless.We already try to fall back to a safe way of building the test-trace
data.frame, this fix just makes it more robust so it no longer emits warnings when it fails to discover asrcrefin the captured test callstack name.