Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR significantly improves the performance of ModISCo (motif discovery) functions in Decima by upgrading to a faster ModISCo implementation and adding new functionality. The primary changes include updating to a faster ModISCo library version, parallelizing attribution loading, and adding seqlet bed file generation.
Key changes:
- Performance optimization through faster ModISCo library and parallel processing
- New motif utility functions for information content, trimming, and motif positioning
- Addition of seqlet bed file generation functionality
Reviewed Changes
Copilot reviewed 11 out of 12 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| setup.cfg | Updates to faster ModISCo library dependency |
| src/decima/utils/motifs.py | New utility functions for motif analysis and trimming |
| src/decima/interpret/modisco.py | Major refactoring with parallelization and new seqlet bed functionality |
| src/decima/core/attribution.py | Parallel processing support for attribution loading |
| src/decima/utils/io.py | BigWig writing improvements and gradient correction options |
| src/decima/hub/init.py | Better error handling for missing model/metadata files |
| src/decima/cli/* | CLI updates to expose new parameters and functionality |
| tests/* | New test coverage for motif utilities and updated existing tests |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
avantikalal
reviewed
Sep 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Speed up for the decima modisco-pattern function:
Old modisco with #22
New modisco jmschrei/tfmodisco-lite#71
Speed up for the decima modisco-reports function:
Old modisco
New modisco
Runtime of attribution prediction shared and takes on L40 for each replicate:
Code to call attributions:
The step to run modisco:
and step to generate motifs: