fixed issue with gc matching #159
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #156
Earlier in
get_gc_matched_intervals, the variablegenomewas reassigned from the genome name (e.g. hg38) to the genome object produced by genomepy and then passed tofilter_blacklist. This led to two issues: 1.filter_blacklistmay fail as this is not a blacklist file; and 2. If the user supplied a custom blacklist file, it would be ignored.Here:
genome_objinstead of genome to avoid reassigning the variable name.get_gc_matched_intervals; the function automatically tries to identify a blacklist file based on the supplied genome. The argument is removed from tutorial 3 as a result.get_gc_matched_intervalsis added.