added swap data

[lovelgeorge99]

Summary by CodeRabbit

• New Features

  • Added support for filtering donations by whether they are swap transactions.
  • Expanded donation details to include transaction IDs, swap transaction metadata, and user wallet addresses.
  • Donation amounts now show both original and swapped token values.

• Bug Fixes

  • Improved accuracy and detail in donation data returned by queries.

[coderabbitai]

Walkthrough

The donationsByQfRoundId GraphQL query and its resolver were updated to accept an optional isSwap boolean parameter. The resolver now joins and returns additional swap transaction fields and the user's wallet address. The query structure and returned fields were expanded to include swap-related metadata and token information.

Changes

File(s)	Change Summary
src/resolvers/donationResolver.ts	Updated the donationsByQfRoundId resolver to accept an optional isSwap argument, join the swapTransaction relation, select new swap and token fields, and filter by isSwap if provided.
test/graphqlQueries.ts	Modified the donationsByQfRoundId GraphQL query to accept an optional isSwap parameter, expanded the returned fields to include swap transaction details, token information, and the user's wallet address.

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant GraphQLServer
    participant DonationResolver
    participant Database

    Client->>GraphQLServer: Query donationsByQfRoundId(qfRoundId, isSwap?)
    GraphQLServer->>DonationResolver: donationsByQfRoundId(qfRoundId, isSwap?)
    DonationResolver->>Database: Query donations (filter by qfRoundId, isSwap if provided, join swapTransaction, select extra fields)
    Database-->>DonationResolver: Return donation records with swap and user wallet info
    DonationResolver-->>GraphQLServer: Return expanded donation data
    GraphQLServer-->>Client: Respond with donation list and metadata

Loading

Possibly related PRs

• added toTokanAmount column in donation #188: Adds the fromTokenAmount property to the Donation entity, which is now utilized and returned by the updated resolver and query.
• Add chain abstraction #171: Introduces the swap transaction table and related donation fields, which are now joined and returned in the updated query.
• added get all donations by qf round id #207: Previously introduced the donationsByQfRoundId resolver, which is directly extended here to support the new isSwap filter and additional fields.

Poem

In fields of code where tokens swap,
A rabbit hops and data pops!
Now queries bring both swap and not,
With wallet, tokens, all well-wrought.
New fields abound, the data flows—
The hoppy dev in sunlight glows! 🐇✨

Tip

⚡️ Faster reviews with caching

• CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure Review - Disable Cache at either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off the Data Retention setting under your Organization Settings.

Enjoy the performance boost—your workflow just got faster.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between be48279 and 03a576d.

📒 Files selected for processing (2)

• src/resolvers/donationResolver.ts (1 hunks)
• test/graphqlQueries.ts (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: test

🔇 Additional comments (7)

src/resolvers/donationResolver.ts (3)

1147-1149: Well-implemented optional parameter for filtering swap transactions.

The addition of the optional isSwap parameter is properly typed as a Boolean with nullable configuration, following GraphQL best practices.

---

1153-1169: Good implementation of joined data selection for swap transactions.

The left join with the swapTransaction table and selection of relevant fields provides comprehensive swap transaction metadata and user wallet address information. This implementation is clean and follows good database query practices.

---

1173-1175: Properly implemented conditional filtering based on the isSwap parameter.

The conditional WHERE clause is correctly implemented, only applying the filter when the parameter is provided. The use of parameterized queries with the :isSwap placeholder helps prevent SQL injection attacks.

test/graphqlQueries.ts (4)

2275-2279: Query parameters aligned with resolver implementation.

The GraphQL query signature has been correctly updated to match the resolver's new parameter, maintaining consistency between client and server interfaces.

---

2281-2284: Enhanced data retrieval with token amounts and transaction ID.

The query now includes transactionId, fromTokenAmount, and aliased toTokenAmount (from amount), providing more comprehensive donation information for swap transactions.

---

2288-2299: Complete swap transaction metadata selection.

The query properly requests the isSwap flag and all relevant swap transaction fields that were added in the resolver, ensuring all necessary swap data is available to the client.

---

2302-2302: Added user wallet address to query response.

Including the user's wallet address in the query result aligns with the resolver changes and provides essential user information for swap transactions.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[ae2079]

Thanks @lovelgeorge99