Skip to content
This repository was archived by the owner on Apr 17, 2025. It is now read-only.

Update depercated urllib3 methods#584

Open
Chrosea wants to merge 1 commit intoGeneralMills:masterfrom
Chrosea:master
Open

Update depercated urllib3 methods#584
Chrosea wants to merge 1 commit intoGeneralMills:masterfrom
Chrosea:master

Conversation

@Chrosea
Copy link
Copy Markdown

@Chrosea Chrosea commented Jun 2, 2023

  1. requests no longer has vendored modules in request.package,
  2. urllib3 deprecated Retry options Retry(method_whitelist=...) in favor of Retry(allowed_methods=...)

1. `requests` no longer has vendored modules in request.package,
2. `urllib3` deprecated Retry options `Retry(method_whitelist=...) `in favor of  `Retry(allowed_methods=...)`
@Terseus
Copy link
Copy Markdown
Contributor

I'm not on my PC right now, I'll take a look on why the pipeline is failing in >3.10 whenever I can.

@Terseus
Copy link
Copy Markdown
Contributor

Found the problem; I think there's a bug in vcrpy with urllib3 that prevents the test suite to work (see kevin1024/vcrpy#719).

The jobs of Python <3.10 works because vcrpy has pinned urllib3 to v1 with Python <3.10 (see kevin1024/vcrpy#699 (comment)).

Sorry but I would prefer to being able to run the test suite before merging this.

In the mean time, if anyone is having trouble with the urllib3 upgrade, pin urllib3<2 in your requirements until this is fixed.

@gl2007
Copy link
Copy Markdown

My VSCode was cribbing with this error "Import "requests.packages.urllib3.util" could not be resolved". Had to change it to "from urllib3.util" for the error to go away. I am a newbie here to py.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants