Merged
Conversation
Author
|
@GenerelSchwerz when |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
right now bot.entity.height is not valid since server-side value is used
Instead it should always be computed client-side eg, wether shift is pressed or not.
issue is here:
mineflayer/lib/plugins/entities.js
Line 489 in ad36612
@GenerelSchwerz you can reproduce current issue by crouching and looking at cursor block on the web client on different angles (you will notice de-sync since camera is updated immediately)
I'm not fixing raycast entity for now as it seems to be a little more complicated (I'm using my own impl from mineflayer-mouse for now).