Remove the incompatibility (regression) between the -I and -Q options. #8643
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See forum post https://forum.generic-mapping-tools.org/t/grdimage-transparency-of-nan-values/5641/11 But testing this further would be good. There must have been some reason to exclude the -I -Q combination.
Member
Member
Author
|
Yes, I guessed so but unless we find a good reason to keep it (the -Q -I conflict) we should remove it. And even if we find, we may restrict that eventual case under an appropriate code condition. |
seisman
approved these changes
Dec 16, 2024
Member
seisman
left a comment
seisman
left a comment
There was a problem hiding this comment.
No new failures. So good to merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See forum post
https://forum.generic-mapping-tools.org/t/grdimage-transparency-of-nan-values/5641/11
But testing this further would be good. There must have been some reason to exclude the -I -Q combination.