Skip to content

Improve the workarounds for handling pandas nullable dtypes in pandas<=2.1 #3596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 12, 2024

Conversation

seisman
Copy link
Member

@seisman seisman commented Nov 7, 2024

Description of proposed changes

This PR is cherry-picked from #3584. See that PR for context. More tests will be added in that PR too.

This PR is an improved version of PR #3505.

Labeling this PR as "bug" and we will merge the two entries for PR #3505 and this PR when we drafting the release changelog.

@seisman seisman added bug Something isn't working needs review This PR has higher priority and needs review. labels Nov 7, 2024
@seisman seisman added this to the 0.14.0 milestone Nov 7, 2024
@seisman seisman removed the needs review This PR has higher priority and needs review. label Nov 7, 2024
@seisman seisman marked this pull request as draft November 8, 2024 02:49
@seisman seisman marked this pull request as ready for review November 9, 2024 14:20
@seisman seisman added needs review This PR has higher priority and needs review. and removed needs review This PR has higher priority and needs review. labels Nov 9, 2024
@seisman seisman marked this pull request as draft November 10, 2024 07:25
@seisman
Copy link
Member Author

seisman commented Nov 10, 2024

Please review the changes in #3584 first. I'll cherry-pick changes in that PR to this PR later.

@seisman seisman added the needs review This PR has higher priority and needs review. label Dec 9, 2024
@seisman seisman marked this pull request as ready for review December 12, 2024 01:28
@seisman seisman removed the needs review This PR has higher priority and needs review. label Dec 12, 2024
@seisman seisman merged commit 4d9f897 into main Dec 12, 2024
26 of 27 checks passed
@seisman seisman deleted the pandas-2.1 branch December 12, 2024 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants