Figure.wiggle: Refactor the parameter fillpositive/fillnegative using the new alias system #4041
+32
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seisman
added
maintenance
seisman
force-pushed
the
refactor/wiggle
branch
from
c635ae8 to
4d3da58
Compare
… the new alias system
seisman
force-pushed
the
refactor/wiggle
branch
from
4d3da58 to
6febfb1
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the Figure.wiggle method to use PyGMT's new alias system for handling the fillpositive and fillnegative parameters. The changes simplify parameter processing by moving the fill logic into a dedicated parser function and utilizing the AliasSystem for parameter mapping.
- Extracted fill parameter logic into a new
_parse_fillshelper function - Updated the alias decorator and AliasSystem to handle fillpositive/fillnegative parameters
- Simplified docstring formatting for fill parameters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the title says.
Preview: https://pygmt-dev--4041.org.readthedocs.build/en/4041/api/generated/pygmt.Figure.wiggle.html