Update the issue template for bumping GMT versions #4167
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seisman
added
maintenance
weiji14
reviewed
Oct 16, 2025
| - [ ] Fix failing tests (1 or more PRs) | ||
| - [ ] Fix failing doctests reported in the ["Doctest" workflow](https://github.com/GenericMappingTools/pygmt/actions/workflows/ci_doctests.yaml) | ||
| - [ ] Fix [xfail](https://docs.pytest.org/en/stable/skipping.html#xfail-mark-test-functions-as-expected-to-fail) pytest markers on tests that are now xpass | ||
| - [ ] Run `grep "# TODO(GMT.*)" **/*.py` to find TODO items related to GMT |
Member
There was a problem hiding this comment.
This grep statement doesn't seem to handle leading whitespaces?
Member
Author
There was a problem hiding this comment.
It works well with leading whitespaces:
$ grep "# TODO(GMT.*)" **/*.py
pygmt/clib/session.py: # TODO(GMT>6.5.0): Remove the workaround for upstream bug in GMT<=6.5.0.
pygmt/src/plot3d.py: # TODO(GMT>6.5.0): Remove the note for the upstream bug of the "straight_line"
pygmt/src/plot.py: # TODO(GMT>6.5.0): Remove the note for the upstream bug of the "straight_line"
pygmt/tests/test_clib_virtualfile_in.py:# TODO(GMT>6.5.0): Remove the xfail marker for GMT<=6.5.0.
pygmt/tests/test_datasets_earth_relief.py:# TODO(GMT X.Y.Z): Upstream bug which is not fixed yet.
pygmt/tests/test_grdimage.py:# TODO(GMT>6.5.0): Remove the xfail marker for GMT<=6.5.0.
Member
There was a problem hiding this comment.
Hmm, it doesn't seem to work for me on my bash shell in Linux. But usually I just use my IDE's 'Find in Project' anyway.
Member
Author
There was a problem hiding this comment.
You're right, **/*.py doesn't work well for Bash (I'm using zsh).
Maybe we should use the following command. Also note that we may have TODO comments in
$ grep -r "# TODO(GMT.*)" --include="*.py" .
./pygmt/clib/session.py: # TODO(GMT>6.5.0): Remove the workaround for upstream bug in GMT<=6.5.0.
./pygmt/tests/test_datasets_earth_relief.py:# TODO(GMT X.Y.Z): Upstream bug which is not fixed yet.
./pygmt/tests/test_grdimage.py:# TODO(GMT>6.5.0): Remove the xfail marker for GMT<=6.5.0.
./pygmt/tests/test_clib_virtualfile_in.py:# TODO(GMT>6.5.0): Remove the xfail marker for GMT<=6.5.0.
./pygmt/src/plot3d.py: # TODO(GMT>6.5.0): Remove the note for the upstream bug of the "straight_line"
./pygmt/src/plot.py: # TODO(GMT>6.5.0): Remove the note for the upstream bug of the "straight_line"
weiji14
approved these changes
Oct 16, 2025
weiji14
reviewed
Oct 16, 2025
Co-authored-by: Wei Ji <[email protected]>
seisman
added
final review call
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the command
grep "# TODO(GMT.*)" **/*.pyto find GMT-related workarounds/patches/xfails.