Fix grdsample and add tests for registration changes #4180
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unify grdsample for filenames and DataArray: load filenames via xarray GMT engine (fallback to path) and, when -T/-r aren’t set, infer registration with grdinfo to align -R/-I.
Don’t mutate DataArray registration, ensure -T isn’t combined with -r, and add a regression test confirming identical outputs for file vs DataArray.
Issues : #3337
Right example: