pygmt.grdsample: Add check and test for exclusive parameters 'toggle' and 'registration'#4183
Merged
seisman merged 21 commits intoGenericMappingTools:mainfrom Nov 8, 2025
Merged
Conversation
Member
Author
Member
|
Could you please run |
Member
Author
Fixed |
Member
Member
seisman
reviewed
Nov 4, 2025
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
Remove note about mutual exclusivity of translate and registration.
seisman
reviewed
Nov 5, 2025
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
seisman
reviewed
Nov 7, 2025
seisman
reviewed
Nov 7, 2025
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
seisman
reviewed
Nov 7, 2025
seisman
reviewed
Nov 7, 2025
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
seisman
approved these changes
Nov 7, 2025
Member
Author
|
The local test failed before, but it works now. |
seisman
reviewed
Nov 7, 2025
seisman
reviewed
Nov 7, 2025
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
Member
|
@Chuan1937 Thank you for contributing to the PyGMT project. Feel free to open a new pull request to add yourself to the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Related to #3337
Preview: N/A