-
Notifications
You must be signed in to change notification settings - Fork 235
Figure.grdview: Add parameters surftype/dpi/mesh_fill/nan_transparent/monochrome to control surfure types #4234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
ce5fc8f to
d3c7bd2
Compare
d3c7bd2 to
2f32c36
Compare
pygmt/src/grdview.py
Outdated
| "image": "c" if nan_transparent is True else "i", | ||
| "waterfallx": "mx", | ||
| "waterfally": "my", | ||
| } | ||
|
|
||
| # surftype was aliased to Q previously. | ||
| _old_surftype_syntax = surftype not in _surtype_mapping and surftype is not None |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a unit test to ensure that backwards compatibility is preserved when a user passes surftype="c", but did not set nan_transparent=True (which is added in this PR). The output grdview plot should still have NaN transparency.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added in aa9eb73.
69c28ef to
16051a0
Compare
Summary of changed imagesThis is an auto-generated report of images that have changed on the DVC remote
Image diff(s)DetailsAdded images
Modified images
Report last updated at commit aa9eb73 |

This PR improves
grdview's-Qoption in a more Pythonic way by splitting it into multiple parameters:surftypedpinan_transparentmonochromemesh_fillAddress #4208 (comment).
Example