Add a note/warning that PS_CONVERT is not supported #4342
Merged
+35
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adds support for GMT's PS_CONVERT configuration parameter in PyGMT's psconvert function. When users call psconvert explicitly, any PS_CONVERT settings configured in their GMT environment will now be used as default options, matching GMT's behavior.
Changes:
- Adds logic to read PS_CONVERT configuration via
lib.get_default() - Parses comma-separated options from PS_CONVERT and injects them as defaults
- Ensures user-provided arguments take precedence over PS_CONVERT settings
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
Contributor
Author
|
Thanks @seisman for the guidance, I have revised it according to Solution 1. |
Member
|
@Chuan1937 Please make changes following the discussions in #4256. Let me know if anything is unclear. |
seisman
changed the title
seisman
added
maintenance
seisman
reviewed
Jan 13, 2026
Co-authored-by: Dongdong Tian <[email protected]>
Co-authored-by: Dongdong Tian <[email protected]>
seisman
reviewed
Jan 13, 2026
seisman
reviewed
Jan 13, 2026
Co-authored-by: Dongdong Tian <[email protected]>
seisman
reviewed
Jan 13, 2026
seisman
approved these changes
Jan 13, 2026
seisman
added
the
final review call
Member
|
Looks good to me. Since it's an enhacenement, not a new feature, I will merge it in 24 hours if no further comments. |
yvonnefroehlich
approved these changes
Jan 13, 2026
Co-authored-by: Yvonne Fröhlich <[email protected]>
Co-authored-by: Yvonne Fröhlich <[email protected]>
Co-authored-by: Yvonne Fröhlich <[email protected]>
seisman
reviewed
Jan 13, 2026
seisman
removed
the
final review call
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a note and warning that PS_CONVERT is not supported in PyGMT.
Fixes #4256
Preview: https://pygmt-dev--4342.org.readthedocs.build/en/4342/api/generated/pygmt.config.html#pygmt.config