-
Notifications
You must be signed in to change notification settings - Fork 229
Add docformatter to format plain text in docstrings #642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 3 commits
17fe7a9
54213f7
b1e6f37
4d4e5bf
18602d6
f4ae7ba
09d1d5c
c102784
e6976d5
8988d66
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -6,6 +6,8 @@ PYTEST_COV_ARGS=--cov=$(PROJECT) --cov-config=../pyproject.toml \ | |||||
--pyargs ${PYTEST_EXTRA} | ||||||
BLACK_FILES=$(PROJECT) setup.py doc/conf.py examples | ||||||
BLACKDOC_OPTIONS=--line-length 79 | ||||||
DOCFORMATTER_FILES=$(PROJECT) setup.py doc/conf.py examples | ||||||
DOCFORMATTER_OPTIONS=--recursive --pre-summary-newline --wrap-summaries 79 --wrap-descriptions 79 | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
Do we want to force """
This is a description.
""" There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, it looks cleaner. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Just find that PEP 257 says:
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Hmm, seems like |
||||||
FLAKE8_FILES=$(PROJECT) setup.py doc/conf.py | ||||||
LINT_FILES=$(PROJECT) setup.py doc/conf.py | ||||||
|
||||||
|
@@ -14,8 +16,8 @@ help: | |||||
@echo "" | ||||||
@echo " install install in editable mode" | ||||||
@echo " test run the test suite (including doctests) and report coverage" | ||||||
@echo " format run black and blackdoc to automatically format the code" | ||||||
@echo " check run code style and quality checks (black, blackdoc, isort and flake8)" | ||||||
@echo " format run black, blackdoc, docformatter and isort to automatically format the code" | ||||||
@echo " check run code style and quality checks (black, blackdoc, docformatter, isort and flake8)" | ||||||
seisman marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||
@echo " lint run pylint for a deeper (and slower) quality check" | ||||||
@echo " clean clean up build and generated files" | ||||||
@echo " distclean clean up build and generated files, including project metadata files" | ||||||
|
@@ -37,11 +39,13 @@ test: | |||||
|
||||||
format: | ||||||
isort . | ||||||
docformatter --in-place $(DOCFORMATTER_OPTIONS) $(DOCFORMATTER_FILES) | ||||||
black $(BLACK_FILES) | ||||||
blackdoc $(BLACKDOC_OPTIONS) $(BLACK_FILES) | ||||||
|
||||||
check: | ||||||
isort . --check | ||||||
docformatter --check $(DOCFORMATTER_OPTIONS) $(DOCFORMATTER_FILES) | ||||||
black --check $(BLACK_FILES) | ||||||
blackdoc --check $(BLACKDOC_OPTIONS) $(BLACK_FILES) | ||||||
flake8 $(FLAKE8_FILES) | ||||||
|
Uh oh!
There was an error while loading. Please reload this page.