Skip to content

Comments

feat: build vlm response (issue #13)#24

Merged
jennifer-bowser merged 43 commits intomainfrom
issue-13-build-vlm-network-response
Dec 17, 2025
Merged

feat: build vlm response (issue #13)#24
jennifer-bowser merged 43 commits intomainfrom
issue-13-build-vlm-network-response

Conversation

@jennifer-bowser
Copy link
Contributor

@jennifer-bowser jennifer-bowser commented Dec 5, 2025

I've hard-coded several fields to be gregor-specific values for expediency. In the future we will need to configure these dynamically.

However, for now I wasn't really sure what to use for these gregor-specific fields so I just took my best guess. Reviewers, please provide feedback on what you think we should use as values for the gregor pilot for the following:

  • HandoverType.id
  • HandoverType.label
  • BeaconHandover.url
  • Meta.beaconId

For reference, the VLM API spec can be found here.

@jennifer-bowser jennifer-bowser self-assigned this Dec 5, 2025
@jennifer-bowser jennifer-bowser changed the title feat: build vlm network response (issue #23) feat: build vlm network response (issue #13) Dec 5, 2025
@jennifer-bowser jennifer-bowser changed the title feat: build vlm network response (issue #13) feat: build vlm response (issue #13) Dec 5, 2025
@jennifer-bowser jennifer-bowser changed the base branch from main to issue-17-stub-vlm-request-endpoint December 5, 2025 18:21
…ata' for now instead of trying to guess how things will be formatted

model_config = SettingsConfigDict(
env_prefix="vlm_",
env_prefix="anyvlm_",
Copy link
Contributor Author

@jennifer-bowser jennifer-bowser Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is unrelated to this ticket but I found one last instance of "vlm" that needed to be updated to "anyvlm"

@jennifer-bowser jennifer-bowser marked this pull request as ready for review December 8, 2025 14:13
@jennifer-bowser jennifer-bowser requested a review from a team as a code owner December 8, 2025 14:13
jennifer-bowser and others added 2 commits December 12, 2025 09:16
Co-authored-by: James Stevenson <james.stevenson@nationwidechildrens.org>
Co-authored-by: James Stevenson <james.stevenson@nationwidechildrens.org>
Copy link
Member

@korikuzma korikuzma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small thing

Copy link
Member

@korikuzma korikuzma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot to import

Co-authored-by: Kori Kuzma <korikuzma@gmail.com>
korikuzma
korikuzma previously approved these changes Dec 15, 2025
Copy link
Member

@korikuzma korikuzma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice 💯

Base automatically changed from issue-17-stub-vlm-request-endpoint to main December 15, 2025 17:11
@jennifer-bowser jennifer-bowser dismissed korikuzma’s stale review December 15, 2025 17:11

The base branch was changed.

@jennifer-bowser jennifer-bowser merged commit cccd752 into main Dec 17, 2025
14 checks passed
@jennifer-bowser jennifer-bowser deleted the issue-13-build-vlm-network-response branch December 17, 2025 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants