-
Notifications
You must be signed in to change notification settings - Fork 0
feat: add anyvlm database #28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
jennifer-bowser
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mostly have a question about how we're configuring our docker setup, but I found a couple of pylance errors/some other nitpicky suggestions as well.
|
TIL my pylance extension was not working (... but is now after some struggles of getting the configs right again) |
| "ga4gh.vrs>=2.2.0,<3.0", | ||
| "ga4gh.va_spec~=0.4.2", | ||
| "biocommons.anyvar@git+https://github.com/biocommons/anyvar.git@main", | ||
| "biocommons.anyvar@git+https://github.com/biocommons/anyvar.git@0d3ab56fe936b27235a1ce136da4641ea81c0bbf", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was having issues locally, so pinned to latest commit
|
For some reason I'm getting failures in |
Can you nuke your dbs? @jennifer-bowser |
Ok I nuked my DBs, but I'm still getting errors. When I check my AnyVar instance after running tests, I'm mostly seeing log output with this kind of error: Maybe this is just wonkyness on my end though, since I'm not sure why your changes would be causing these tests to fail and my AnyVar/AnyVLM environment has been challenging lately. UPDATE: Never mind, I had the wrong version of vrs-python installed in my AnyVar instance. |
jennifer-bowser
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I got my tests to pass, thanks Kori!
close #23