Skip to content

Conversation

@korikuzma
Copy link
Member

@korikuzma korikuzma commented Dec 11, 2025

close #23

@korikuzma korikuzma self-assigned this Dec 11, 2025
@korikuzma korikuzma requested a review from a team December 11, 2025 19:25
@korikuzma korikuzma added enhancement New feature or request priority:medium Medium priority labels Dec 11, 2025
@korikuzma korikuzma marked this pull request as draft December 12, 2025 17:46
@korikuzma korikuzma marked this pull request as ready for review December 12, 2025 19:28
Copy link
Contributor

@jennifer-bowser jennifer-bowser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mostly have a question about how we're configuring our docker setup, but I found a couple of pylance errors/some other nitpicky suggestions as well.

@korikuzma
Copy link
Member Author

TIL my pylance extension was not working (... but is now after some struggles of getting the configs right again)

@korikuzma korikuzma changed the title feat: add anyvlm database feat: add vlm database Dec 16, 2025
@korikuzma korikuzma marked this pull request as draft December 17, 2025 15:20
@korikuzma korikuzma changed the title feat: add vlm database feat: add anyvlm database Dec 17, 2025
@korikuzma korikuzma marked this pull request as ready for review December 23, 2025 14:43
"ga4gh.vrs>=2.2.0,<3.0",
"ga4gh.va_spec~=0.4.2",
"biocommons.anyvar@git+https://github.com/biocommons/anyvar.git@main",
"biocommons.anyvar@git+https://github.com/biocommons/anyvar.git@0d3ab56fe936b27235a1ce136da4641ea81c0bbf",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was having issues locally, so pinned to latest commit

@korikuzma korikuzma requested a review from a team December 23, 2025 14:44
@jsstevenson jsstevenson self-requested a review December 23, 2025 19:43
@jennifer-bowser
Copy link
Contributor

For some reason I'm getting failures in test_clients.py; though it looks like these are all passing when GitHub runs them so maybe I've got something whack going on in my local environment?

FAILED tests/unit/anyvar/test_clients.py::test_put_allele_expressions[anyvar_python_client] - AssertionError: assert ['ga4gh:VA.ru...G6bLwQesDU2g'] == ['ga4gh:VA.0y...0Nv8OMN359HC']
FAILED tests/unit/anyvar/test_clients.py::test_put_allele_expressions[anyvar_http_client] - AssertionError: assert ['ga4gh:VA.ru...G6bLwQesDU2g'] == ['ga4gh:VA.0y...0Nv8OMN359HC']
FAILED tests/unit/anyvar/test_clients.py::test_put_allele_expressions_handle_invalid[anyvar_http_client] - anyvlm.anyvar.base_client.AnyVarClientError
FAILED tests/unit/anyvar/test_clients.py::test_search_by_interval[anyvar_populated_python_client] - AssertionError: assert [Allele(id='g...g(root='C')))] == [Allele(id='g...nitLength=1))]
FAILED tests/unit/anyvar/test_clients.py::test_search_by_interval[anyvar_http_client] - AssertionError: assert [Allele(id='g...g(root='C')))] == [Allele(id='g...nitLength=1))]
FAILED tests/unit/anyvar/test_clients.py::test_search_by_interval_with_alias[anyvar_populated_python_client] - AssertionError: assert [Allele(id='g...g(root='C')))] == [Allele(id='g...nitLength=1))]
FAILED tests/unit/anyvar/test_clients.py::test_search_by_interval_with_alias[anyvar_http_client] - AssertionError: assert [Allele(id='g...g(root='C')))] == [Allele(id='g...nitLength=1))]

@korikuzma
Copy link
Member Author

korikuzma commented Dec 24, 2025

For some reason I'm getting failures in test_clients.py; though it looks like these are all passing when GitHub runs them so maybe I've got something whack going on in my local environment?

FAILED tests/unit/anyvar/test_clients.py::test_put_allele_expressions[anyvar_python_client] - AssertionError: assert ['ga4gh:VA.ru...G6bLwQesDU2g'] == ['ga4gh:VA.0y...0Nv8OMN359HC']
FAILED tests/unit/anyvar/test_clients.py::test_put_allele_expressions[anyvar_http_client] - AssertionError: assert ['ga4gh:VA.ru...G6bLwQesDU2g'] == ['ga4gh:VA.0y...0Nv8OMN359HC']
FAILED tests/unit/anyvar/test_clients.py::test_put_allele_expressions_handle_invalid[anyvar_http_client] - anyvlm.anyvar.base_client.AnyVarClientError
FAILED tests/unit/anyvar/test_clients.py::test_search_by_interval[anyvar_populated_python_client] - AssertionError: assert [Allele(id='g...g(root='C')))] == [Allele(id='g...nitLength=1))]
FAILED tests/unit/anyvar/test_clients.py::test_search_by_interval[anyvar_http_client] - AssertionError: assert [Allele(id='g...g(root='C')))] == [Allele(id='g...nitLength=1))]
FAILED tests/unit/anyvar/test_clients.py::test_search_by_interval_with_alias[anyvar_populated_python_client] - AssertionError: assert [Allele(id='g...g(root='C')))] == [Allele(id='g...nitLength=1))]
FAILED tests/unit/anyvar/test_clients.py::test_search_by_interval_with_alias[anyvar_http_client] - AssertionError: assert [Allele(id='g...g(root='C')))] == [Allele(id='g...nitLength=1))]

Can you nuke your dbs? @jennifer-bowser

@jennifer-bowser
Copy link
Contributor

jennifer-bowser commented Dec 24, 2025

For some reason I'm getting failures in test_clients.py; though it looks like these are all passing when GitHub runs them so maybe I've got something whack going on in my local environment?

FAILED tests/unit/anyvar/test_clients.py::test_put_allele_expressions[anyvar_python_client] - AssertionError: assert ['ga4gh:VA.ru...G6bLwQesDU2g'] == ['ga4gh:VA.0y...0Nv8OMN359HC']
FAILED tests/unit/anyvar/test_clients.py::test_put_allele_expressions[anyvar_http_client] - AssertionError: assert ['ga4gh:VA.ru...G6bLwQesDU2g'] == ['ga4gh:VA.0y...0Nv8OMN359HC']
FAILED tests/unit/anyvar/test_clients.py::test_put_allele_expressions_handle_invalid[anyvar_http_client] - anyvlm.anyvar.base_client.AnyVarClientError
FAILED tests/unit/anyvar/test_clients.py::test_search_by_interval[anyvar_populated_python_client] - AssertionError: assert [Allele(id='g...g(root='C')))] == [Allele(id='g...nitLength=1))]
FAILED tests/unit/anyvar/test_clients.py::test_search_by_interval[anyvar_http_client] - AssertionError: assert [Allele(id='g...g(root='C')))] == [Allele(id='g...nitLength=1))]
FAILED tests/unit/anyvar/test_clients.py::test_search_by_interval_with_alias[anyvar_populated_python_client] - AssertionError: assert [Allele(id='g...g(root='C')))] == [Allele(id='g...nitLength=1))]
FAILED tests/unit/anyvar/test_clients.py::test_search_by_interval_with_alias[anyvar_http_client] - AssertionError: assert [Allele(id='g...g(root='C')))] == [Allele(id='g...nitLength=1))]

Can you nuke your dbs? @jennifer-bowser

Ok I nuked my DBs, but I'm still getting errors. When I check my AnyVar instance after running tests, I'm mostly seeing log output with this kind of error:

ga4gh.vrs.dataproxy.DataProxyValidationError: Reference mismatch at GRCh38:Y position 2781760-2781761 (input gave 'A' but correct ref is 'C')

Maybe this is just wonkyness on my end though, since I'm not sure why your changes would be causing these tests to fail and my AnyVar/AnyVLM environment has been challenging lately.

UPDATE: Never mind, I had the wrong version of vrs-python installed in my AnyVar instance.

Copy link
Contributor

@jennifer-bowser jennifer-bowser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got my tests to pass, thanks Kori!

@korikuzma korikuzma merged commit dd56494 into main Dec 24, 2025
14 checks passed
@korikuzma korikuzma deleted the issue-23 branch December 24, 2025 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request priority:medium Medium priority

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Stand up a VLM Database

4 participants