-
Notifications
You must be signed in to change notification settings - Fork 0
feat!: add starting_assembly as argument when using genomic_to_tx_segment #391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
2f36fdb
Add work to support residue coords + refactor offset calculation
jarbesfeld 49ef3df
Fix docstrings
jarbesfeld fd0e88a
Merge branch 'main' into issue-383
jarbesfeld 99beca0
Refactor genomic_to_tx_segment
jarbesfeld 310a16c
Merge branch 'main' into issue-383
jarbesfeld fc54151
Add translate_identifier
jarbesfeld 6774927
Fix liftover issues
jarbesfeld 9bc2c31
Store requested changes
jarbesfeld 3a7c914
Add support for providing assembly
jarbesfeld 6bad2f9
Merge branch 'main' into issue-390
jarbesfeld 4ab9fa0
Merge branch 'main' into issue-390
jarbesfeld 18f74d9
Add more comments
jarbesfeld 232673d
Correct docstring in _validate_gene_coordinates
jarbesfeld 1c03cac
Update assembly parameter, add chromosome as an optional parameter
jarbesfeld 1aff449
Resolve merge conflicts
jarbesfeld 4b336ba
Ensure merge conflicts are resolved
jarbesfeld 44e1f34
Add docstring, change liftover data access
jarbesfeld 0734fbd
Remove duplicate error statement
jarbesfeld 39b4a75
Update logic for genomic accession validation
jarbesfeld 06244a9
Update docstring
jarbesfeld 2f6b224
Indicate that accession version will be ignored
jarbesfeld File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it worth adding something in the docstrings (for both private + public method) about version will be ignored for GRCh37?