-
Notifications
You must be signed in to change notification settings - Fork 0
fix!: Edit logic in genomic breakpoint validator in exon_genomic_coords.py #406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
korikuzma
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are there existing tests for this?
|
@korikuzma There had been an existing test for this but it looks like it was accidentally removed when I merged in main. I will add this test back. |
|
Not sure if I need to add the test back considering we now have a warning statement as opposed to an error statement. |
You can check the caplog: https://docs.pytest.org/en/stable/how-to/logging.html#caplog-fixture |
|
@ahwagner I modified the warning statement string a bit based on your feedback (see last commit). Please let me know if you would like to add the base pair distance computation part back. |
korikuzma
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks fine to me, let's wait for @ahwagner 's confirmation on the change.
|
@korikuzma Discussed with Alex and he approves |
closes #404