Skip to content

Conversation

@jarbesfeld
Copy link
Contributor

closes #404

  • Introduces a 150bp extension between the genomic coordinates for the start and end exons in a transcript. Breakpoints that occur beyond this boundary are likely erroneous.

@jarbesfeld jarbesfeld requested a review from ahwagner May 16, 2025 18:00
@jarbesfeld jarbesfeld self-assigned this May 16, 2025
@jarbesfeld jarbesfeld added enhancement New feature or request priority:low Low priority stale-exempt labels May 16, 2025
@jarbesfeld jarbesfeld requested a review from korikuzma May 28, 2025 16:20
Copy link
Member

@korikuzma korikuzma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there existing tests for this?

@jarbesfeld
Copy link
Contributor Author

jarbesfeld commented May 29, 2025

@korikuzma There had been an existing test for this but it looks like it was accidentally removed when I merged in main. I will add this test back.

@jarbesfeld jarbesfeld requested a review from korikuzma May 29, 2025 12:39
korikuzma
korikuzma previously approved these changes May 29, 2025
@jarbesfeld
Copy link
Contributor Author

Not sure if I need to add the test back considering we now have a warning statement as opposed to an error statement.

@korikuzma
Copy link
Member

Not sure if I need to add the test back considering we now have a warning statement as opposed to an error statement.

You can check the caplog: https://docs.pytest.org/en/stable/how-to/logging.html#caplog-fixture

@jarbesfeld
Copy link
Contributor Author

@ahwagner I modified the warning statement string a bit based on your feedback (see last commit). Please let me know if you would like to add the base pair distance computation part back.

Copy link
Member

@korikuzma korikuzma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks fine to me, let's wait for @ahwagner 's confirmation on the change.

@jarbesfeld
Copy link
Contributor Author

@korikuzma Discussed with Alex and he approves

@jarbesfeld jarbesfeld requested a review from korikuzma June 20, 2025 17:50
@jarbesfeld jarbesfeld merged commit 8cafe54 into main Jun 20, 2025
18 of 35 checks passed
@jarbesfeld jarbesfeld deleted the issue-404 branch June 20, 2025 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request priority:low Low priority stale-exempt

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Edit genomic breakpoint validator from exon_genomic_coords.py

3 participants