feat: Add is_exonic field to transcript segment output
#423
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jarbesfeld
added
enhancement
korikuzma
reviewed
Sep 7, 2025
| genomic_location: SequenceLocation = Field( | ||
| ..., description="The genomic position of a transcript segment." | ||
| ) | ||
| is_exonic: bool = Field( |
Member
There was a problem hiding this comment.
Kind of related to this PR... If the genomic location should only contain one of: start or end, then we should add a validator for this (separate issue).
The reason why I was thinking is if there's ever a case where the location would be a region that could include both exon/intron data.
Contributor
Author
There was a problem hiding this comment.
That makes sense to me. seg_start and seg_end each should only contain one coordinate as they describe either the start or end of the transcript segment. To confirm, is this something we could add in a different PR?
korikuzma
approved these changes
Sep 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #422
A new field called
is_exonicis added which indicates whether or not the position at the start or end of a transcript segment occurs on an exon.