fix: don't quote an already quoted url field

[zealws]

At present, CST doesn't connect to UTA databases correctly if the password has special characters.

The database URL includes a password field, which is already embedded within a valid URL. The value was url quoted when the URL was generated, so it doesn't need to be quoted a second time when the URL is consumed by the UTA database code.

I tested this using a password local@$%dev and it attempted to authenticate with the password local%40%24%25dev. After this PR, it correctly uses the single-unquoted value.

[jsstevenson]

I think this is fine. Having taken another look, I am maybe a little confused as to when the first quoting happens, but I don't think this class needs to be in the business of quoting the connection string anyway

[zealws]

I am maybe a little confused as to when the first quoting happens

It's where the URL is generated, prior to being set in the environment (outside of CST).

Consider a password that has :. If you embed that (without quoting) into a URL, it is no longer a valid URL. So if a consumer wants to use a password with : in it, they will have to quote it in order to generate a valid URL.

From CST's point of view, it received a fully-formed URL. It is safe to assume that the password field was already quoted if it needed to be. If it wasn't quoted but it should have been, then the URL is invalid and CST should just return an error (which it will do when it parses the URL).