feat: add fastapi + service_info endpoint #78
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Member
Author
|
oh, a possible TODO here is that ruff includes a fastapi-specific set of lints we could use |
korikuzma
previously approved these changes
Jan 6, 2025
korikuzma
requested changes
Jan 8, 2025
Member
There was a problem hiding this comment.
Looks like there's still some merge conflicts that need resolved
korikuzma
approved these changes
Jan 8, 2025
jsstevenson
added a commit
to cancervariants/disease-normalization
that referenced
this pull request
Mar 12, 2025
#231) * implement GenomicMedLab/software-templates#78 * Don't introduce env logic into DB construction, since I know that's a whole can of worms (but it would be nice to do this eventually). * Filled in some more documentation to have a place to briefly describe this. --------- Co-authored-by: Kori Kuzma <[email protected]>
jsstevenson
added a commit
to cancervariants/metakb
that referenced
this pull request
Jul 1, 2025
Add `python-dotenv` to backend entry points. This is a simple quality-of-life improvement driven by my unending frustration with the mountain of environment variables upon which metakb sits. Store a `.env` file in `server/` and it'll load env vars from there. * I have aspirations for a more featureful configuration experience. I'd made an initial attempt [here](GenomicMedLab/software-templates#78) but I'm not totally happy with it. I have an issue [here](GenomicMedLab/software-templates#106) to take up someday where I try and do something better, but I think that would entail implementation in all of the library dependencies first. For now I think this PR is just fine though.
hmcostello
pushed a commit
to cancervariants/metakb
that referenced
this pull request
Oct 17, 2025
Add `python-dotenv` to backend entry points. This is a simple quality-of-life improvement driven by my unending frustration with the mountain of environment variables upon which metakb sits. Store a `.env` file in `server/` and it'll load env vars from there. * I have aspirations for a more featureful configuration experience. I'd made an initial attempt [here](GenomicMedLab/software-templates#78) but I'm not totally happy with it. I have an issue [here](GenomicMedLab/software-templates#106) to take up someday where I try and do something better, but I think that would entail implementation in all of the library dependencies first. For now I think this PR is just fine though.
korikuzma
pushed a commit
to cancervariants/metakb
that referenced
this pull request
Oct 30, 2025
Add `python-dotenv` to backend entry points. This is a simple quality-of-life improvement driven by my unending frustration with the mountain of environment variables upon which metakb sits. Store a `.env` file in `server/` and it'll load env vars from there. * I have aspirations for a more featureful configuration experience. I'd made an initial attempt [here](GenomicMedLab/software-templates#78) but I'm not totally happy with it. I have an issue [here](GenomicMedLab/software-templates#106) to take up someday where I try and do something better, but I think that would entail implementation in all of the library dependencies first. For now I think this PR is just fine though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #75
this became much bigger than planned, but it reflects a few aspirations for what a service-like application should probably look like
api.pymodule, including a/service_infoendpoint conforming to the GA4GH spec. I didn't bother implementingupdatedAt(it's optional) because I think it'd be kind of a hassle to update a datetime object every time we make a release. Maybe there's a way to automate this but not a priority IMO.testanddebug) are sort of general/predictive of what we might need in a given app. Lots of examples online also set aDB URLor DB connection configs here as well. (I also looked atpydantic-settingsfor this but I think it's a lot more than we need. )FASTrules fromruff.The service info spec lets you add your own additional fields if desired. For DGIdb, Adam added a "data version" field, for example. There's probably things we could do there for many of our APIs.