[Fixes #2184] Saving map layer settings for a dataset calls the wrong URL

[dsuren1]

Description

This PR resolves unnecessary style update calls triggered during dataset updates when no style changes are made. It also fixes the incorrect pending indicator caused by style comparison issues.

Issue

• Saving map layer settings for a dataset calls the wrong URL #2184

[gemini-code-assist]

Summary of Changes

Hello @dsuren1, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a bug where saving map layer settings for a dataset would inadvertently trigger style update calls, even when no style modifications had occurred. The changes introduce more precise mechanisms for identifying and comparing the initial style of a dataset layer, ensuring that style-related updates are only dispatched when a genuine change has been made. This improves efficiency and prevents erroneous API calls during dataset updates.

Highlights

• Improved Initial Style Retrieval: New selectors (getInitialDatasetResource, getInitialDatasetLayerStyle) have been introduced to accurately fetch the initial style of a dataset layer, ensuring the system correctly identifies the layer's original state.
• Corrected Style Comparison Logic: The isResourceDataEqual selector was modified to compare the current layer style against the actual initial style, effectively preventing false positives for style changes and unnecessary update calls.
• Enhanced Resource Saving: The saving mechanism now ensures that the default_style is correctly included in the saved resource object, which is crucial for accurate style comparisons in subsequent operations.
• Prevention of Unwanted Style Updates: The overall changes stop the system from making unnecessary style update calls when a dataset's style has not actually been modified, leading to more efficient and correct behavior.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request addresses an issue where updating a dataset's map layer settings incorrectly triggered a style update. The changes correctly identify the initial style of a dataset and use it for comparison, which prevents these unwanted updates. The refactoring of selectors in resource.js is a good improvement for code clarity and reusability. I have a couple of suggestions to enhance code robustness and fix a minor typo.

[giohappy]

@dsuren1 we have a conflict here.