Fix #2155 : Download Metadata XML and update submodule #2190
Conversation
Summary of ChangesHello @anup39, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses issue #2155 by modernizing the metadata download capabilities. It introduces a dedicated mechanism for fetching ISO metadata XML, enhancing the system's ability to provide standardized data. Concurrently, the legacy Dublin Core download feature has been deprecated and removed, streamlining the codebase and reducing maintenance overhead. A significant update to the MapStore2 submodule is also included, ensuring the project benefits from the latest upstream developments and bug fixes. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request correctly updates the metadata download URL and removes the deprecated Dublin Core download functionality, including related components and configurations. The MapStore2 submodule has also been updated as intended. The changes are logical and well-contained. I've provided a couple of suggestions to improve code style and remove a potential debugging leftover in a test file.
| export const getMetadataDownloadLinkByPk = (pk) => { | ||
| return getEndpointUrl(RESOURCES, `/${pk}/iso_metadata_xml`); | ||
| } |
There was a problem hiding this comment.
For conciseness and improved readability, this function can be simplified into a single-line arrow function with an implicit return. This is a common pattern for functions that only contain a return statement.
export const getMetadataDownloadLinkByPk = (pk) => getEndpointUrl(RESOURCES, `/${pk}/iso_metadata_xml`);|
|
||
| describe('gnDownloadMetaData epic', () => { | ||
| beforeEach(done => { | ||
| global.__DEVTOOLS__ = true; |
There was a problem hiding this comment.
This line appears to be a debugging leftover. Setting global variables within tests is generally discouraged as it can lead to side effects and make tests less isolated and predictable. Please remove this line.
| global.__DEVTOOLS__ = true; | ||
| setTimeout(done); | ||
| }); | ||
| afterEach(done => { |
There was a problem hiding this comment.
| afterEach(done => { | |
| afterEach(done => { | |
| delete global.__DEVTOOLS__; |
2 participants
This PR adds following: