Skip to content

Conversation

@allyoucanmap
Copy link
Collaborator

This PR fixes some problems with the submodule update:

  • review style for footer refactor
  • review dev dependencies in mapstore-project
  • remove intl

@allyoucanmap allyoucanmap requested a review from anup39 October 28, 2025 09:56
@allyoucanmap allyoucanmap linked an issue Oct 28, 2025 that may be closed by this pull request
@gemini-code-assist
Copy link

Summary of Changes

Hello @allyoucanmap, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses several issues related to a submodule update by focusing on dependency optimization and UI layout consistency. It removes an unnecessary intl polyfill, refines the styling and positioning of the map footer component, and standardizes the MapFooter plugin's configuration across the application to ensure its correct rendering and behavior.

Highlights

  • Dependency Cleanup: The conditional import for the intl polyfill has been removed, streamlining the internationalization setup as it's likely no longer needed or handled by modern environments.
  • Footer Styling Refinements: CSS adjustments have been made to the map footer, including setting a z-index for proper layering within the page viewer and ensuring the mouse position element's height is automatically managed.
  • MapFooter Configuration Standardization: The MapFooter plugin's configuration has been updated across various localConfig.json entries and its pluginsConfig.json definition to explicitly set containerPosition: "footer", ensuring consistent placement.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the CesiumJS version and introduces several related fixes, including removing the intl polyfill and refactoring the footer. The changes are generally good and align with the stated objectives. I've provided a couple of suggestions to improve maintainability and ensure CSS rules are effective. Specifically, I've pointed out some redundant configuration in localConfig.json that can be simplified, and a potential issue with a z-index property that might require a position property to work correctly.

Copy link
Member

@anup39 anup39 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@allyoucanmap

  • The intl dependency error is solved. I checked with Chrome and Firefox no issues in loading locale
  • MapFooter and its elements (mouseposition) are rendering as expected.

@allyoucanmap allyoucanmap merged commit 9e136aa into GeoNode:master Oct 28, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update CesiumJS version

2 participants