[Fixes #1893] Changing settings of a 3D Tiles resource throws an error

[dsuren1]

Description

This PR modifies the update process for the 3D Tiles subtype resource

Issue

• Changing settings of a 3D Tiles resource throws an error #1893

[gemini-code-assist]

Summary of Changes

Hello @dsuren1, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves an error encountered when modifying settings for 3D Tiles resources. It achieves this by implementing a more flexible resource update mechanism, which includes a new generic API endpoint for resource patching and conditional logic to apply the correct update method based on the resource's subtype. Additionally, the PR enhances the accuracy of resource state tracking by improving the comparison logic for resource attributes.

Highlights

• New API Endpoint for Resource Updates: A new updateResource API function has been introduced in geonode_mapstore_client/client/js/api/geonode/v2/index.js to handle generic resource updates using PATCH requests, returning the updated resource data.
• Conditional Resource Update Logic: The resource saving epic in geonode_mapstore_client/client/js/epics/gnsave.js now dynamically selects the appropriate update function (updateResourceAPI or updateDataset) based on whether the resource is a 'default dataset subtype'. This ensures specific resource types, like 3D Tiles, are updated correctly.
• Improved Attribute Comparison Logic: The isAttributesEqual function in geonode_mapstore_client/client/js/selectors/resource.js has been refined to correctly compare resource attributes, explicitly handling cases where attribute fields might be empty to prevent incorrect state detection.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces a fix for updating 3D Tiles resources by adding a generic updateResource API endpoint and using it for non-default dataset subtypes. The changes look correct and effectively address the issue. I've also noticed an improvement in handling time series updates. I have one suggestion to refactor a complex promise chain using async/await to improve code readability and maintainability.