-
Notifications
You must be signed in to change notification settings - Fork 127
Fix: Swipe not initialization correctly with saved config #2224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @dsuren1, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a critical issue where map configurations, particularly those affecting dynamic plugins like 'Swipe', were not correctly initialized when a map had an associated viewer. The root cause was that map settings were applied before the necessary plugin reducers were fully loaded, preventing plugins from properly restoring their state. The fix ensures that the map configuration is now applied only after all required reducers are ready, guaranteeing correct plugin initialization and state restoration from saved settings. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request effectively resolves an initialization issue where map configurations were applied before plugin reducers were loaded, preventing plugins from using saved configurations. The solution correctly defers applying the map configuration by waiting for a REDUCERS_LOADED action, with a sensible timeout as a fallback. The implementation is solid and directly addresses the problem described. I have one minor suggestion to improve code maintainability.
(cherry picked from commit 4b1bf95)
) (cherry picked from commit 4b1bf95) Co-authored-by: Suren <[email protected]>
Description
This PR fixes an issue where the map configuration are applied before the plugins and their reducers, preventing the plugins from initializing with the saved configuration when the map has an associated map viewer (context)