Skip to content

Conversation

@dsuren1
Copy link

@dsuren1 dsuren1 commented Nov 20, 2025

Description

This PR fixes an issue where the map configuration are applied before the plugins and their reducers, preventing the plugins from initializing with the saved configuration when the map has an associated map viewer (context)

@dsuren1 dsuren1 added this to the 5.0.0 milestone Nov 20, 2025
@dsuren1 dsuren1 requested a review from allyoucanmap November 20, 2025 09:58
@dsuren1 dsuren1 added bug Something isn't working master geonode-ui labels Nov 20, 2025
@gemini-code-assist
Copy link

Summary of Changes

Hello @dsuren1, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical issue where map configurations, particularly those affecting dynamic plugins like 'Swipe', were not correctly initialized when a map had an associated viewer. The root cause was that map settings were applied before the necessary plugin reducers were fully loaded, preventing plugins from properly restoring their state. The fix ensures that the map configuration is now applied only after all required reducers are ready, guaranteeing correct plugin initialization and state restoration from saved settings.

Highlights

  • Delayed Map Configuration: The application of map configuration is now delayed until after all plugin reducers have been loaded, specifically when a map has an associated viewer. This ensures plugins can correctly initialize with saved settings.
  • Reducer Readiness Check: A new mechanism has been introduced to wait for the REDUCERS_LOADED action, ensuring dynamic plugin reducers are ready to restore their state from the saved configuration before the map is configured. A 5-second timeout acts as a safety fallback.
  • Action Stream Propagation: The action$ stream is now explicitly passed through to the resource configuration options, enabling the epic to listen for reducer loading events and orchestrate the delayed configuration.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request effectively resolves an initialization issue where map configurations were applied before plugin reducers were loaded, preventing plugins from using saved configurations. The solution correctly defers applying the map configuration by waiting for a REDUCERS_LOADED action, with a sensible timeout as a fallback. The implementation is solid and directly addresses the problem described. I have one minor suggestion to improve code maintainability.

@allyoucanmap allyoucanmap merged commit 4b1bf95 into GeoNode:master Nov 26, 2025
6 checks passed
github-actions bot pushed a commit that referenced this pull request Nov 26, 2025
allyoucanmap pushed a commit that referenced this pull request Nov 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants