-
Notifications
You must be signed in to change notification settings - Fork 127
Fix - Download button tooltip #2228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @dsuren1, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves a UI bug concerning the download button's tooltip in the Dataset detail viewer panel. It introduces a specific property for managing the tooltip's message ID within the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request fixes an issue where the download button's tooltip was incorrect in the Dataset detail viewer. The changes introduce a new tooltipId prop to the DownloadButton component to allow for a separate tooltip message from the button's display text. This is then configured in localConfig.json for the specific viewer. The implementation is correct and solves the issue. I've added one suggestion to improve the robustness and backward compatibility of the component by adjusting how the default tooltipId is determined. Overall, good work.
* Fix - Download button tooltip * inline comment (cherry picked from commit da185b4)
* Fix - Download button tooltip * inline comment (cherry picked from commit da185b4) Co-authored-by: Suren <[email protected]>
Description
This PR fixes the tooltip of the download button in Dataset detail viewer panel
Screenshot