Skip to content

Conversation

@dsuren1
Copy link

@dsuren1 dsuren1 commented Nov 21, 2025

Description

This PR fixes the tooltip of the download button in Dataset detail viewer panel

Screenshot

Screenshot 2025-11-21 at 5 00 53 PM

@dsuren1 dsuren1 added this to the 5.0.0 milestone Nov 21, 2025
@dsuren1 dsuren1 requested a review from allyoucanmap November 21, 2025 11:32
@dsuren1 dsuren1 self-assigned this Nov 21, 2025
@dsuren1 dsuren1 added the bug Something isn't working label Nov 21, 2025
@gemini-code-assist
Copy link

Summary of Changes

Hello @dsuren1, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a UI bug concerning the download button's tooltip in the Dataset detail viewer panel. It introduces a specific property for managing the tooltip's message ID within the DownloadButton component and updates the application's configuration to utilize this new property, thereby ensuring the correct tooltip text is displayed to users.

Highlights

  • Download Button Tooltip Fix: The pull request addresses an issue where the download button in the Dataset detail viewer panel displayed an incorrect tooltip. This fix ensures the tooltip accurately reflects the button's function.
  • Component Prop Introduction: A new tooltipId prop has been introduced to the DownloadButton component in DownloadResource.jsx. This prop allows for a dedicated message ID to be used for the tooltip, separate from the downloadMsgId.
  • Configuration Update: The localConfig.json file has been updated to include the new tooltipId property for the DownloadResource plugin, setting its value to gnviewer.download to correctly display the download tooltip.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request fixes an issue where the download button's tooltip was incorrect in the Dataset detail viewer. The changes introduce a new tooltipId prop to the DownloadButton component to allow for a separate tooltip message from the button's display text. This is then configured in localConfig.json for the specific viewer. The implementation is correct and solves the issue. I've added one suggestion to improve the robustness and backward compatibility of the component by adjusting how the default tooltipId is determined. Overall, good work.

@dsuren1 dsuren1 assigned allyoucanmap and unassigned dsuren1 Nov 21, 2025
@giohappy giohappy merged commit da185b4 into GeoNode:master Nov 24, 2025
5 checks passed
github-actions bot pushed a commit that referenced this pull request Nov 24, 2025
* Fix - Download button tooltip

* inline comment

(cherry picked from commit da185b4)
giohappy pushed a commit that referenced this pull request Nov 24, 2025
* Fix - Download button tooltip

* inline comment

(cherry picked from commit da185b4)

Co-authored-by: Suren <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants