Enable Public and Approved options only when ADW is activated

[dsuren1]

Description

This PR adds advanced workflow options to the GeoNode settings and uses them to display the published and approved statuses in the ResourceDetail panel

Issue

• Enable Public and Approved options only when ADW is activated #2219

[gemini-code-assist]

Summary of Changes

Hello @dsuren1, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a more flexible and configurable approach to managing resource publishing and approval workflows within GeoNode. By integrating backend settings with frontend UI logic, it ensures that advanced options like 'Public' and 'Approved' statuses are only presented to users when the relevant administrative features are explicitly enabled. This enhances the system's adaptability to different organizational workflows without requiring code changes for configuration adjustments.

Highlights

• Conditional Display of Resource Options: The 'Public' (is_published) and 'Approved' (is_approved) options for resources are now conditionally displayed in the frontend, appearing only when their corresponding advanced workflow settings are activated in the GeoNode backend.
• Backend Setting Integration: The Django settings RESOURCE_PUBLISHING and ADMIN_MODERATE_UPLOADS are now exposed to the frontend configuration, enabling dynamic control over UI elements based on server-side workflow activation.
• Refactored Resource Property Definitions: The ResourceUtils.js file has been refactored to introduce base property definitions and filter functions, allowing for the dynamic removal of specific resource properties (is_published, is_approved) based on the new GeoNode settings.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly implements the feature to conditionally show 'Public' and 'Approved' options based on GeoNode settings. The changes in the Python backend to pass the settings and in the HTML template to receive them are well done. In ResourceUtils.js, the logic to filter the properties based on these settings is correct.

I have one suggestion in ResourceUtils.js regarding the pattern used for initializing configuration-dependent constants. While the current implementation works, a more robust and maintainable approach is suggested for better testability and to avoid potential issues if the configuration were to become dynamic.

Additionally, it would be beneficial to add unit tests for the new functions in ResourceUtils.js to ensure they behave as expected and to prevent future regressions.