Skip to content

Conversation

@allyoucanmap
Copy link
Collaborator

This PR includes latest beckport from MapStore stable branch

@allyoucanmap allyoucanmap added this to the 5.0.0 milestone Nov 26, 2025
@allyoucanmap allyoucanmap requested a review from dsuren1 November 26, 2025 15:43
@gemini-code-assist
Copy link

Summary of Changes

Hello @allyoucanmap, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request integrates the latest stable updates from the MapStore project, specifically targeting the 5.0.x release series. It achieves this by updating the MapStore2 submodule to a newer commit and adjusting the @mapstore/project dependency to point to the geonode-5.0.x branch, ensuring compatibility and access to the latest features and fixes.

Highlights

  • MapStore Submodule Update: The MapStore2 Git submodule has been updated to a new commit (8d9678ae60f4527310c9b3d0b3cdd05f6ee78305) to align with the 5.0.x version.
  • Project Dependency Branch Change: The @mapstore/project dependency in package.json has been switched from tracking the master branch to the geonode-5.0.x branch.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the MapStore submodule and its corresponding project tooling dependency to align with the 5.0.x version. The changes are straightforward and logical. I have added one suggestion to improve build reproducibility by pinning the @mapstore/project devDependency to a specific commit hash instead of a branch name. This is a best practice for ensuring stable and consistent builds over time.

"license": "BSD-2-Clause",
"devDependencies": {
"@mapstore/project": "git+https://github.com/geosolutions-it/mapstore-project.git#master",
"@mapstore/project": "git+https://github.com/geosolutions-it/mapstore-project.git#geonode-5.0.x",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For improved build reproducibility, it is recommended to pin this dependency to a specific commit hash instead of a branch name. While using the geonode-5.0.x branch is an improvement over master, the branch can still receive further updates. This could lead to inconsistencies if npm install is run at different times, making builds non-reproducible. Pinning to a commit hash ensures that every build uses the exact same version of the dependency, which is a practice already followed for the MapStore2 submodule in this same PR.

@dsuren1 dsuren1 merged commit a052e7c into GeoNode:5.0.x Nov 27, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants