-
Notifications
You must be signed in to change notification settings - Fork 127
Add the error message when the process fails #2345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the error message when the process fails #2345
Conversation
Summary of ChangesHello @subashtiwari1010, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the user experience by introducing robust error handling for asynchronous resource operations. It ensures that users are promptly informed via toast notifications when resource cloning or deletion processes encounter failures, providing clear and localized error messages. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces error notifications for failed asynchronous processes like cloning and deleting resources. The changes include a new epic, gnHandleAsyncProcessErrors, to centrally handle these failures and dispatch notifications, along with updates to translation files for the new error messages. My review has identified a couple of areas for improvement. In geonode_mapstore_client/client/js/epics/index.js, the logic for determining the error message title could be more robust. More importantly, in geonode_mapstore_client/client/js/plugins/ExecutionTracker/index.jsx, there appears to be duplicate error handling logic that will likely cause redundant notifications. I've provided specific comments and suggestions to address these points.
Related tasks
Fixes #2333
Describe this PR
This PR adds the error message toast in the top right when the processes i.e. cloning, and deleting fails.