Skip to content

Conversation

@subashtiwari1010
Copy link

Related tasks

Fixes #2333

Describe this PR

This PR adds the error message toast in the top right when the processes i.e. cloning, and deleting fails.

@subashtiwari1010 subashtiwari1010 added bug Something isn't working master 5.0.x labels Jan 22, 2026
@gemini-code-assist
Copy link

Summary of Changes

Hello @subashtiwari1010, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the user experience by introducing robust error handling for asynchronous resource operations. It ensures that users are promptly informed via toast notifications when resource cloning or deletion processes encounter failures, providing clear and localized error messages.

Highlights

  • Error Notification for Failed Processes: Implemented a new epic, gnHandleAsyncProcessErrors, to detect and display error notifications when asynchronous processes like cloning or deleting resources fail. This ensures users receive immediate feedback on operation failures.
  • Integration with Execution Tracker: The ExecutionTracker component now actively monitors for failed processes related to a specific resource and triggers an error notification with a relevant message, improving the user experience during resource management.
  • Internationalization Support: Added new translation keys (errorCloningTitle, errorDeletingTitle) across multiple language files to provide localized titles for cloning and deleting error messages.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces error notifications for failed asynchronous processes like cloning and deleting resources. The changes include a new epic, gnHandleAsyncProcessErrors, to centrally handle these failures and dispatch notifications, along with updates to translation files for the new error messages. My review has identified a couple of areas for improvement. In geonode_mapstore_client/client/js/epics/index.js, the logic for determining the error message title could be more robust. More importantly, in geonode_mapstore_client/client/js/plugins/ExecutionTracker/index.jsx, there appears to be duplicate error handling logic that will likely cause redundant notifications. I've provided specific comments and suggestions to address these points.

@allyoucanmap allyoucanmap merged commit e0207b9 into GeoNode:master Jan 22, 2026
1 check passed
subashtiwari1010 added a commit to subashtiwari1010/geonode-mapstore-client that referenced this pull request Jan 23, 2026
subashtiwari1010 added a commit to subashtiwari1010/geonode-mapstore-client that referenced this pull request Jan 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

5.0.x bug Something isn't working master

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cloning stuck with backend reporting failed state

2 participants