Skip to content

Conversation

@dsuren1
Copy link

@dsuren1 dsuren1 commented Jan 22, 2026

Description

This PR updates extends configurability of msPluginsBlocks not just limited to ResourcesGrid & ResourcesFiltersForm

@gemini-code-assist
Copy link

Summary of Changes

Hello @dsuren1, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refactors the plugin configuration mechanism within the MapStore client to be more adaptable. It transitions from a fixed set of configurable plugins to a dynamic system where the list of configurable plugins is automatically generated from the msPluginsBlocks array. This change streamlines the process of adding new configurable plugins and reduces the need for manual code updates.

Highlights

  • Dynamic Plugin Configurability: The pull request introduces a dynamic approach to determine which plugins are configurable. Instead of a hardcoded list, the system now derives the configurable plugin names directly from the msPluginsBlocks array.
  • Removal of Hardcoded List: The static configurablePlugins array, which previously limited configurability to ResourcesGrid and ResourcesFiltersForm, has been removed.
  • Improved Flexibility: This change significantly enhances the flexibility of the MapStore client, allowing any plugin defined within msPluginsBlocks to be configurable without requiring further code modifications.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request generalizes the configuration of msPluginsBlocks, removing a hardcoded list of plugins. The implementation is functionally correct, but I've identified an opportunity for improvement in terms of performance and code safety. The current approach has a quadratic time complexity and mutates the input configuration object, which can lead to side effects. I've provided a suggestion to refactor the logic to be more efficient (linear time complexity) and to avoid mutation, improving the overall robustness of the code.

Copy link

@subashtiwari1010 subashtiwari1010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Approved.

@subashtiwari1010 subashtiwari1010 merged commit 94b0bb5 into GeoNode:master Jan 22, 2026
github-actions bot pushed a commit that referenced this pull request Jan 22, 2026
subashtiwari1010 pushed a commit that referenced this pull request Jan 22, 2026
@giohappy giohappy modified the milestones: 5.0.0, 5.0.2, 5.0.1 Jan 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants