Skip to content

[Backport 5.0.x] #2437: Fix facets API requests to include current page resource type#2440

Merged
allyoucanmap merged 1 commit intoGeoNode:5.0.xfrom
dsuren1:#2437_backport_5.0.x
Mar 24, 2026
Merged

[Backport 5.0.x] #2437: Fix facets API requests to include current page resource type#2440
allyoucanmap merged 1 commit intoGeoNode:5.0.xfrom
dsuren1:#2437_backport_5.0.x

Conversation

@dsuren1
Copy link
Copy Markdown

@dsuren1 dsuren1 commented Mar 23, 2026

Description

This PR fixes the facets API requests to include current page resource type

Issue

@dsuren1 dsuren1 added this to the 5.0.1 milestone Mar 23, 2026
@dsuren1 dsuren1 requested a review from allyoucanmap March 23, 2026 12:07
@dsuren1 dsuren1 added bug Something isn't working Backport geonode-ui 5.0.x labels Mar 23, 2026
@gemini-code-assist
Copy link
Copy Markdown

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses an issue where facet API requests were not correctly filtering resources based on the specific resource type of the current page. By introducing a defaultQuery configuration to the ResourcesFiltersForm on relevant HTML templates, the system now automatically includes the appropriate resource type filter (e.g., "dashboard", "dataset", "map") in API calls, leading to more accurate and context-aware search results and resource displays across the application.

Highlights

  • MapStore2 Subproject Update: The MapStore2 subproject has been updated to a newer commit (e0ccf8b from d72945f), incorporating upstream changes.
  • Facets API Filtering Enhancement: Configured the ResourcesFiltersForm in various resource listing pages (dashboards, datasets, documents, geostories, maps) to include a defaultQuery parameter, ensuring that facet API requests automatically filter by the current page's specific resource type.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request fixes an issue where facet API requests did not include the current page's resource type. The change involves adding a defaultQuery to the ResourcesFiltersForm configuration in several template files. While the fix is correct and consistently applied, it adds to existing code duplication across these files. I have added a review comment with a suggestion to address this maintainability issue through a future refactoring.

@allyoucanmap allyoucanmap merged commit 2fc182d into GeoNode:5.0.x Mar 24, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Requests to the facets APIs do not take into account the resource type of the current page

2 participants