Fix the view for non-spatial datasets has broken raster viewers#2464
Merged
allyoucanmap merged 1 commit intoGeoNode:masterfrom Mar 27, 2026
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request simplifies the logic for identifying resources without geometry by replacing the checkIfGeometryAttributeIsNull utility function with a direct check for the 'tabular' subtype in gnresource.js. Consequently, the checkIfGeometryAttributeIsNull function and its unused import of isGeometryType have been removed from ResourceUtils.js. I have no feedback to provide.
allyoucanmap
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related tasks
Fixes #2463
Describe this PR
This PR updates the condition to display the tabular dataset / non-spatial dataset. It only applies the non-spatial view when the dataset has tabular sub type.