Finalize backport of style fixes to metadata page#2473
Merged
Conversation
giohappy
requested review from
allyoucanmap and
anup39
and removed request for
allyoucanmap
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the metadata styling in the GeoNode theme by removing an unnecessary !important declaration from horizontal rules and setting a minimum width for definition terms within a grid layout. A review comment suggests replacing the hardcoded 200px value with a LESS variable to enhance maintainability and consistency.
| grid-template-columns: max-content auto; | ||
| padding: 0 0.75rem; | ||
| dt { | ||
| min-width: 200px; |
There was a problem hiding this comment.
To improve maintainability, it's better to use variables instead of magic numbers. Consider defining 200px as a LESS variable in a centralized variables file (e.g., _variables.less) and using it here. This makes future updates to layout values easier and more consistent.
anup39
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.