Skip to content

Conversation

@mattiagiupponi
Copy link
Contributor

… proxy allowed hosts when GeoNode runs asynchoronously

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • Commit message must be in the form "[Fixes #<issue_number>] Title of the Issue"
  • PR title must be in the form "[Fixes #<issue_number>] Title of the PR"
  • New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • This PR passes the QA checks: black geonode && flake8 geonode
  • Commits changing the settings, UI, existing user workflows, or adding new functionality, need to include documentation updates
  • Commits adding new texts do use gettext and have updated .po / .mo files (without location infos)

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

… proxy allowed hosts when GeoNode runs asynchoronously
@mattiagiupponi mattiagiupponi added this to the 4.4.2 milestone Jan 27, 2025
@mattiagiupponi mattiagiupponi self-assigned this Jan 27, 2025
@cla-bot cla-bot bot added the cla-signed CLA Bot: community license agreement signed label Jan 27, 2025
@mattiagiupponi
Copy link
Contributor Author

Importer PR GeoNode/geonode-importer#282

@codecov
Copy link

codecov bot commented Jan 27, 2025

Codecov Report

Attention: Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 61.46%. Comparing base (de98ae6) to head (443fc32).
Report is 15 commits behind head on 4.4.x.

Additional details and impacted files
@@            Coverage Diff             @@
##            4.4.x   #12852      +/-   ##
==========================================
- Coverage   64.14%   61.46%   -2.68%     
==========================================
  Files         890      890              
  Lines       53774    53782       +8     
  Branches     6629     6630       +1     
==========================================
- Hits        34492    33059    -1433     
- Misses      17766    19242    +1476     
+ Partials     1516     1481      -35     
🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@giohappy giohappy merged commit 38527fe into 4.4.x Mar 14, 2025
13 of 14 checks passed
@giohappy giohappy deleted the bp_issue_12828 branch March 14, 2025 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed CLA Bot: community license agreement signed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

New remote datasets are not registered inside proxy allowed hosts when GeoNode runs asynchoronously

3 participants