Skip to content

Conversation

@Gpetrak
Copy link
Member

@Gpetrak Gpetrak commented Jan 28, 2025

Checklist

Reviewing is a process done by project maintainers, mostly on a volunteer basis. We try to keep the overhead as small as possible and appreciate if you help us to do so by completing the following items. Feel free to ask in a comment if you have troubles with any of them.

For all pull requests:

  • Confirm you have read the contribution guidelines
  • You have sent a Contribution Licence Agreement (CLA) as necessary (not required for small changes, e.g., fixing typos in the documentation)
  • Make sure the first PR targets the master branch, eventual backports will be managed later. This can be ignored if the PR is fixing an issue that only happens in a specific branch, but not in newer ones.

The following are required only for core and extension modules (they are welcomed, but not required, for contrib modules):

  • There is a ticket in https://github.com/GeoNode/geonode/issues describing the issue/improvement/feature (a notable exemption is, changes not visible to end-users)
  • The issue connected to the PR must have Labels and Milestone assigned
  • PR for bug fixes and small new features are presented as a single commit
  • Commit message must be in the form "[Fixes #<issue_number>] Title of the Issue"
  • PR title must be in the form "[Fixes #<issue_number>] Title of the PR"
  • New unit tests have been added covering the changes, unless there is an explanation on why the tests are not necessary/implemented
  • This PR passes all existing unit tests (test results will be reported by travis-ci after opening this PR)
  • This PR passes the QA checks: black geonode && flake8 geonode
  • Commits changing the settings, UI, existing user workflows, or adding new functionality, need to include documentation updates
  • Commits adding new texts do use gettext and have updated .po / .mo files (without location infos)

Submitting the PR does not require you to check all items, but by the time it gets merged, they should be either satisfied or inapplicable.

This branch includes fixes in terms of the fields management through through the GET method of the endpoint: /api/v2/datasets//timeseries . Also the functionality of copying the time dimension (if exists) in a layer through the /copy was added.

@cla-bot cla-bot bot added the cla-signed CLA Bot: community license agreement signed label Jan 28, 2025
@Gpetrak Gpetrak requested a review from giohappy January 28, 2025 08:52
@codecov
Copy link

codecov bot commented Jan 28, 2025

Codecov Report

Attention: Patch coverage is 22.22222% with 14 lines in your changes missing coverage. Please review.

Project coverage is 67.96%. Comparing base (5eaad8a) to head (46a3b36).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #12853      +/-   ##
==========================================
- Coverage   67.97%   67.96%   -0.02%     
==========================================
  Files         977      977              
  Lines       59040    59054      +14     
  Branches     6897     6899       +2     
==========================================
+ Hits        40132    40135       +3     
- Misses      17266    17275       +9     
- Partials     1642     1644       +2     

@giohappy giohappy linked an issue Jan 28, 2025 that may be closed by this pull request
@giohappy giohappy added this to the 5.0.0 milestone Feb 5, 2025
@giohappy giohappy merged commit fbee678 into master Feb 5, 2025
16 of 18 checks passed
@giohappy giohappy deleted the fixes_12766 branch February 5, 2025 14:46
@mattiagiupponi mattiagiupponi removed this from the 5.0.0 milestone Oct 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed CLA Bot: community license agreement signed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement an API for timeseries settings

4 participants